This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajssd
commented
Oct 16, 2020
@@ -1,8 +1,29 @@ | |||
hub: docker.io/istio | |||
tag: 1.6.3 | |||
tag: 1.7.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hub and tag were manually modified because istio is still shipping bad config in releases.
surajssd
commented
Oct 16, 2020
Labels: map[string]string{ | ||
"istio-operator-managed": "Reconcile", | ||
"istio-injection": "disabled", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Istio added istio operator namespace config. And it was added with above labels.
invidian
previously approved these changes
Oct 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Release Notes: https://github.com/istio/istio/releases/tag/1.7.3 Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/update-istio
branch
from
October 16, 2020 08:21
879212d
to
c858c17
Compare
This commit adds tests that verify if conversion of the `profile` parameter happens correctly. Another test is added to verify if the servicemonitor is created when `enable_monitoring` is set to true. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/update-istio
branch
from
October 16, 2020 08:41
c858c17
to
d4072e6
Compare
invidian
approved these changes
Oct 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes: https://github.com/istio/istio/releases/tag/1.7.3