Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Commit

Permalink
google-cloud: Remove deprecated automatic_restart field
Browse files Browse the repository at this point in the history
* In terraform-provider-google v0.1.3, it is no longer neccessary
to supply a (duplicated) value for the instance_template field
automatic_restart
* Previously this field was set to match the scheduling
automatic_restart since the field defaulted to true and would
cause plan to always show changes were needed
  • Loading branch information
dghubble committed Aug 25, 2017
1 parent 6a574d4 commit 056bd8a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Typhoon provides a Terraform Module for each supported operating system and plat
## Docs

* [https://typhoon.psdn.io](https://typhoon.psdn.io)
* [Getting Started](https://typhoon.psdn.io/getting-started/)
* [Concepts](https://typhoon.psdn.io/concepts/)
* [Bare-Metal](https://typhoon.psdn.io/bare-metal/)
* [Digital Ocean](https://typhoon.psdn.io/digital-ocean/)
* [Google-Cloud](https://typhoon.psdn.io/google-cloud/)
Expand All @@ -44,12 +44,12 @@ module "yavin-cluster" {
zone = "us-central1-c"
dns_zone = "example.com"
dns_zone_name = "example-zone"
os_image = "coreos-stable-1409-7-0-v20170719"
os_image = "coreos-stable-1465-6-0-v20170817"
# Cluster
cluster_name = "yavin"
controller_count = 1
worker_count = 3
worker_count = 2
ssh_authorized_key = "${var.ssh_authorized_key}"
# output assets dir
Expand Down
3 changes: 0 additions & 3 deletions google-cloud/container-linux/controllers/controllers.tf
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ resource "google_compute_instance_template" "controller" {
preemptible = "${var.preemptible}"
}

# QUIRK: Undocumented field defaults to true if not set
automatic_restart = "${var.preemptible ? false : true}"

disk {
auto_delete = true
boot = true
Expand Down
3 changes: 0 additions & 3 deletions google-cloud/container-linux/workers/workers.tf
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ resource "google_compute_instance_template" "worker" {
preemptible = "${var.preemptible}"
}

# QUIRK: Undocumented field defaults to true if not set
automatic_restart = "${var.preemptible ? false : true}"

disk {
auto_delete = true
boot = true
Expand Down

0 comments on commit 056bd8a

Please sign in to comment.