Allow writing mnemonics in ~A line #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds mnemonics_header and data_section_header to writer.py:write The former is boolean controlling whether it occurs or not (off by default for backwards compatibility). The latter allows the prefix to be controlled e.g. "~A" vs "~ASCII". The mnemonic headers are right-aligned based on the numeric value's column width, so that a fixed-width formatting parser can read it in. If the mnemonics are too long, then they are just placed one following the other, out of alignment.
kinverarity1
added
the
las-writer-code
dcslagel
requested changes
May 18, 2021
Add tests for data-section-header column names
dcslagel
reviewed
May 19, 2021
dcslagel
approved these changes
Jun 10, 2021
Optional changes for the data-header-line (#465) branch
|
Thanks for the review and comments, and changes! 🎉 I will merge shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial implementation of #375 - also ref SO question https://stackoverflow.com/questions/60329481/how-to-add-curve-header-to-output-of-las-write-with-lasio-py/66939467#66939467
Adds mnemonics_header and data_section_header keyword arguments to
writer.py:write. The former is boolean controlling whether it occurs or not (off by default for backwards compatibility). The latter allows the prefix to be controlled e.g. "~A" vs "~ASCII".The mnemonic headers are right-aligned based on the numeric value's column width, so that a fixed-width formatting parser can read it in. If the mnemonics are too long, then they are just placed one following the other, out of alignment.
See https://gist.github.com/kinverarity1/aaf3459c3fa3eeafe127c9011c15c835 for a demo.