Skip to content

Comments

fix: make space id to optional in move app api#66

Merged
nameless-mc merged 1 commit intomasterfrom
fix/make-space-param-optional-in-move-app-request
Nov 26, 2025
Merged

fix: make space id to optional in move app api#66
nameless-mc merged 1 commit intomasterfrom
fix/make-space-param-optional-in-move-app-request

Conversation

@nameless-mc
Copy link
Contributor

Why

2024年9月のkintone APIアップデートにより、アプリの所属するスペースを変更するAPI (/k/v1/app/move.json)
spaceパラメーターが省略可能になりました。省略時またはnullを指定した場合、アプリがスペースから除外される仕様に変更されました。

この変更により、Java Clientの実装も最新のAPI仕様に合わせる必要があります。

関連issue: https://github.com/kintone/project-items/issues/484
API仕様: https://cybozu.dev/ja/kintone/docs/rest-api/apps/settings/move-app/

What

  • MoveAppRequest.javaspaceフィールドのJavadocを更新
    • (required)(optional)に変更
    • 「If set to null or not set, the App will be removed from its current space」と明記
  • AppClient.javaに新しいmove(long app)メソッドを追加
    • スペースからアプリを削除する専用メソッド(Javaでは引数の省略ができないため)
    • 内部的にmove(app, null)を呼び出す
  • 既存のmove(long app, Long space)メソッドのJavadocを更新
    • nullを指定した場合の動作を明記
  • 既存のmove(MoveAppRequest request)メソッドのJavadocを整理
    • @returnの記述から不適切な位置にあったパラメーター説明を削除
  • AppClientTest.javamoveToSpace_long()テストを追加
    • 新しいmove(long app)メソッドの動作を検証

How to test

Checklist

  • Read CONTRIBUTING.md at the repository.
  • Updated documentation if it is required.
  • Added/updated tests if it is required. (or tested manually)

@nameless-mc nameless-mc self-assigned this Nov 12, 2025
Copilot AI review requested due to automatic review settings November 12, 2025 05:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Java Client to align with the September 2024 kintone API update, which made the space parameter optional in the Move App API (/k/v1/app/move.json). When omitted or set to null, the app is now removed from its space.

Key changes:

  • Made the space field optional in MoveAppRequest and updated its documentation
  • Added a new move(long app) convenience method to remove apps from spaces
  • Updated Javadoc across all affected methods to clarify null behavior

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/main/java/com/kintone/client/api/app/MoveAppRequest.java Updated Javadoc to mark space field as optional and clarify null behavior
src/main/java/com/kintone/client/AppClient.java Added new move(long app) method and updated Javadoc for existing move methods
src/test/java/com/kintone/client/AppClientTest.java Added test for new move(long app) method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nameless-mc nameless-mc merged commit 4bc5182 into master Nov 26, 2025
8 checks passed
@nameless-mc nameless-mc deleted the fix/make-space-param-optional-in-move-app-request branch November 26, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants