fix: make space id to optional in move app api#66
Merged
nameless-mc merged 1 commit intomasterfrom Nov 26, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Java Client to align with the September 2024 kintone API update, which made the space parameter optional in the Move App API (/k/v1/app/move.json). When omitted or set to null, the app is now removed from its space.
Key changes:
- Made the
spacefield optional inMoveAppRequestand updated its documentation - Added a new
move(long app)convenience method to remove apps from spaces - Updated Javadoc across all affected methods to clarify null behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/com/kintone/client/api/app/MoveAppRequest.java | Updated Javadoc to mark space field as optional and clarify null behavior |
| src/main/java/com/kintone/client/AppClient.java | Added new move(long app) method and updated Javadoc for existing move methods |
| src/test/java/com/kintone/client/AppClientTest.java | Added test for new move(long app) method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chihiro-adachi
approved these changes
Nov 12, 2025
shabaraba
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
2024年9月のkintone APIアップデートにより、アプリの所属するスペースを変更するAPI (
/k/v1/app/move.json)の
spaceパラメーターが省略可能になりました。省略時またはnullを指定した場合、アプリがスペースから除外される仕様に変更されました。この変更により、Java Clientの実装も最新のAPI仕様に合わせる必要があります。
関連issue: https://github.com/kintone/project-items/issues/484
API仕様: https://cybozu.dev/ja/kintone/docs/rest-api/apps/settings/move-app/
What
MoveAppRequest.javaのspaceフィールドのJavadocを更新(required)→(optional)に変更AppClient.javaに新しいmove(long app)メソッドを追加move(app, null)を呼び出すmove(long app, Long space)メソッドのJavadocを更新move(MoveAppRequest request)メソッドのJavadocを整理@returnの記述から不適切な位置にあったパラメーター説明を削除AppClientTest.javaにmoveToSpace_long()テストを追加move(long app)メソッドの動作を検証How to test
Checklist