Skip to content

feat: add new property to AppSettings APIs #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shabaraba merged 1 commit into from
Jan 30, 2025
Merged

feat: add new property to AppSettings APIs #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/com/kintone/client/api/app/GetAppSettingsPreviewResponseBody.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ public class GetAppSettingsPreviewResponseBody implements KintoneResponseBody {
/** The "duplicate record" feature is enabled. */
private final boolean enableDuplicateRecord;

/** The inline record editing feature is enabled. */
private final boolean enableInlineRecordEditing;

/** The revision number of the App settings. */
private final long revision;
}
3 changes: 3 additions & 0 deletions src/main/java/com/kintone/client/api/app/GetAppSettingsResponseBody.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ public class GetAppSettingsResponseBody implements KintoneResponseBody {
/** The "duplicate record" feature is enabled. */
private final boolean enableDuplicateRecord;

/** The inline record editing feature is enabled. */
private final boolean enableInlineRecordEditing;

/** The revision number of the App settings. */
private final long revision;
}
6 changes: 6 additions & 0 deletions src/main/java/com/kintone/client/api/app/UpdateAppSettingsRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,12 @@ public class UpdateAppSettingsRequest implements KintoneRequest {
*/
private Boolean enableDuplicateRecord;

/**
* The on/off settings of inline record editing feature (optional). If set to null, leaves this
* setting unchanged.
*/
private Boolean enableInlineRecordEditing;

/**
* The expected revision number of the App settings (optional). The request will fail if the
* revision number is not the latest revision. The revision will not be checked if this parameter
Expand Down
8 changes: 7 additions & 1 deletion src/test/java/com/kintone/client/AppClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import static org.assertj.core.api.Assertions.assertThat;

import com.google.common.collect.Lists;
import com.kintone.client.api.app.*;
import com.kintone.client.model.Entity;
import com.kintone.client.model.EntityType;
Expand Down Expand Up @@ -44,6 +43,7 @@
import java.util.Collections;
import java.util.List;
import java.util.Map;
import org.assertj.core.util.Lists;
import org.junit.jupiter.api.Test;

public class AppClientTest {
Expand Down Expand Up @@ -670,6 +670,7 @@ public void getAppSettings_long() {
true,
true,
true,
true,
10L);
mockClient.setResponseBody(resp);

Expand All @@ -694,6 +695,7 @@ public void getAppSettings_long_String() {
true,
true,
true,
true,
10L);
mockClient.setResponseBody(resp);

Expand All @@ -719,6 +721,7 @@ public void getAppSettings_GetAppSettingsRequest() {
true,
true,
true,
true,
1);
mockClient.setResponseBody(resp);

Expand All @@ -742,6 +745,7 @@ public void getAppSettingsPreview_long() {
true,
true,
true,
true,
10L);
mockClient.setResponseBody(resp);

Expand All @@ -766,6 +770,7 @@ public void getAppSettingsPreview_long_String() {
true,
true,
true,
true,
10L);
mockClient.setResponseBody(resp);

Expand All @@ -791,6 +796,7 @@ public void getAppSettingsPreview_GetAppSettingsPreviewRequest() {
true,
true,
true,
true,
1);
mockClient.setResponseBody(resp);

Expand Down