Skip to content

docs(rest): add descriptions of functions and options #3267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 14, 2025
Merged

Conversation

chihiro-adachi
Copy link
Contributor

@chihiro-adachi chihiro-adachi commented Apr 10, 2025

Why

  • Add descriptions of functions and options.

What

  • Update README.md

How to test

  • Only document updates

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@Copilot Copilot AI review requested due to automatic review settings April 10, 2025 08:00
@chihiro-adachi chihiro-adachi requested a review from a team as a code owner April 10, 2025 08:00
@chihiro-adachi chihiro-adachi requested review from tasshi-me and shabaraba and removed request for a team April 10, 2025 08:00
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

packages/rest/README.md:143

  • Replace the curly quotes with straight quotes for consistency, e.g. 'Please specify "oauth".'
| type       |  String  |   Yes    | Please specify “oauth”.                                                                                                                                                                 |

Comment on lines 136 to 143
| type | String | Yes | Please specify “apiToken”. |
| apiToken | String or String[] | Yes | You can pass multiple api tokens as an array of string. |

#### 3. Parameters for [OAuth authentication](https://kintone.dev/en/docs/common/authentication/how-to-add-oauth-clients/)

| Name | Type | Required | Description |
|------------|:------:| :------: |----------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| type | String | Yes | Please specify “oauth”. |
Copy link
Preview

Copilot AI Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the curly quotes with straight quotes for consistency, e.g. 'Please specify "apiToken".'

Suggested change
| type | String | Yes | Please specify apiToken. |
| apiToken | String or String[] | Yes | You can pass multiple api tokens as an array of string. |
#### 3. Parameters for [OAuth authentication](https://kintone.dev/en/docs/common/authentication/how-to-add-oauth-clients/)
| Name | Type | Required | Description |
|------------|:------:| :------: |----------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| type | String | Yes | Please specify oauth. |
| type | String | Yes | Please specify "apiToken". |
| apiToken | String or String[] | Yes | You can pass multiple api tokens as an array of string. |
#### 3. Parameters for [OAuth authentication](https://kintone.dev/en/docs/common/authentication/how-to-add-oauth-clients/)
| Name | Type | Required | Description |
|------------|:------:| :------: |----------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| type | String | Yes | Please specify "oauth". |

Copilot uses AI. Check for mistakes.

Copy link
Contributor Author

@chihiro-adachi chihiro-adachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

補足コメント

@@ -1,18 +1,17 @@
# @kintone/rest

[![npm version](https://badge.fury.io/js/@kintone%2Frest.svg)](https://badge.fury.io/js/@kintone%2Frest)
![Node.js version](https://img.shields.io/badge/dynamic/json.svg?url=https://raw.githubusercontent.com/kintone/js-sdk/main/packages/rest/package.json&label=node&query=$.engines.node&colorB=blue)
![Node.js version](https://img.shields.io/badge/node-%3E%3D20-blue)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いったん静的で >= 20 を指定


| [<img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/edge/edge_48x48.png" alt="Edge" width="24px" height="24px" />](http://godban.github.io/browsers-support-badges/)<br/>Edge | [<img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/firefox/firefox_48x48.png" alt="Firefox" width="24px" height="24px" />](http://godban.github.io/browsers-support-badges/)<br/>Firefox | [<img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/chrome/chrome_48x48.png" alt="Chrome" width="24px" height="24px" />](http://godban.github.io/browsers-support-badges/)<br/>Chrome | [<img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/safari/safari_48x48.png" alt="Safari" width="24px" height="24px" />](http://godban.github.io/browsers-support-badges/)<br/>Safari |
| ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| Latest version | Latest version | Latest version | Latest version |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest versionで問題ないか念の為確認

| certAuth.pfx | [Buffer](https://nodejs.org/api/buffer.html#buffer_class_buffer) | | The [client certificate file](https://jp.cybozu.help/general/en/user/list_access/remote/webbrowser.html). Required, unless you specify `pfxFilePath`. |
| certAuth.pfxFilePath | String | | The path to [client certificate file](https://jp.cybozu.help/general/en/user/list_access/remote/webbrowser.html). Required, unless you specify `pfx`. |
| certAuth.password | String | | The password of client certificate. |
| proxy | Object | | **This parameter is available only in Node.js environment.**<br />If you use a proxy, please specify its configuration. |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest-api-clientはfalseも指定できたが、restでは不要

| basicAuth.username | String | | The username of Basic authentication. |
| basicAuth.password | String | | The password of Basic authentication. |
| httpsAgent | Object | | **This parameter is available only in Node.js environment.**<br />The custom HTTPS agent to be used when request.<br />The agent should be compatible with [undici.Agent](https://github.com/nodejs/undici/blob/main/docs/docs/api/Agent.md). |
| certAuth | Object | | **This parameter is available only in Node.js environment.**<br />**When `httpsAgent` parameter is given, this parameter is unavailable.**<br />If your Kintone environment uses [Client Certificate authentication](https://jp.cybozu.help/general/en/admin/list_security/list_access/secureaccess.html), please specify the certificate file and password. |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clientCertAuth -> certAuth に変更

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clientCertAuthが正

| basicAuth | Object | | If your Kintone environment uses Basic authentication, please specify its username and password. |
| basicAuth.username | String | | The username of Basic authentication. |
| basicAuth.password | String | | The password of Basic authentication. |
| httpsAgent | Object | | **This parameter is available only in Node.js environment.**<br />The custom HTTPS agent to be used when request.<br />The agent should be compatible with [undici.Agent](https://github.com/nodejs/undici/blob/main/docs/docs/api/Agent.md). |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http.Agent -> undici.Agentに変更


| Name | Type | Required | Description |
|----------|:------:|:--------:|----------------------------|
| type | String | Yes | Please specify "password". |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typeパラメータで認証方式を指定するようになったので追加

@chihiro-adachi chihiro-adachi changed the title doc(rest): add descriptions of functions and options docs(rest): add descriptions of functions and options Apr 10, 2025
chihiro-adachi and others added 2 commits April 10, 2025 17:24
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@chihiro-adachi chihiro-adachi merged commit c501024 into main Apr 14, 2025
18 checks passed
@chihiro-adachi chihiro-adachi deleted the doc-readme branch April 14, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants