-
Notifications
You must be signed in to change notification settings - Fork 59
docs(rest): add descriptions of functions and options #3267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
packages/rest/README.md:143
- Replace the curly quotes with straight quotes for consistency, e.g. 'Please specify "oauth".'
| type | String | Yes | Please specify “oauth”. |
packages/rest/README.md
Outdated
| type | String | Yes | Please specify “apiToken”. | | ||
| apiToken | String or String[] | Yes | You can pass multiple api tokens as an array of string. | | ||
|
||
#### 3. Parameters for [OAuth authentication](https://kintone.dev/en/docs/common/authentication/how-to-add-oauth-clients/) | ||
|
||
| Name | Type | Required | Description | | ||
|------------|:------:| :------: |----------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| type | String | Yes | Please specify “oauth”. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace the curly quotes with straight quotes for consistency, e.g. 'Please specify "apiToken".'
| type | String | Yes | Please specify “apiToken”. | | |
| apiToken | String or String[] | Yes | You can pass multiple api tokens as an array of string. | | |
#### 3. Parameters for [OAuth authentication](https://kintone.dev/en/docs/common/authentication/how-to-add-oauth-clients/) | |
| Name | Type | Required | Description | | |
|------------|:------:| :------: |----------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | |
| type | String | Yes | Please specify “oauth”. | | |
| type | String | Yes | Please specify "apiToken". | | |
| apiToken | String or String[] | Yes | You can pass multiple api tokens as an array of string. | | |
#### 3. Parameters for [OAuth authentication](https://kintone.dev/en/docs/common/authentication/how-to-add-oauth-clients/) | |
| Name | Type | Required | Description | | |
|------------|:------:| :------: |----------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | |
| type | String | Yes | Please specify "oauth". | |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
補足コメント
@@ -1,18 +1,17 @@ | |||
# @kintone/rest | |||
|
|||
[](https://badge.fury.io/js/@kintone%2Frest) | |||
 | |||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
いったん静的で >= 20
を指定
|
||
| [<img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/edge/edge_48x48.png" alt="Edge" width="24px" height="24px" />](http://godban.github.io/browsers-support-badges/)<br/>Edge | [<img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/firefox/firefox_48x48.png" alt="Firefox" width="24px" height="24px" />](http://godban.github.io/browsers-support-badges/)<br/>Firefox | [<img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/chrome/chrome_48x48.png" alt="Chrome" width="24px" height="24px" />](http://godban.github.io/browsers-support-badges/)<br/>Chrome | [<img src="https://raw.githubusercontent.com/alrra/browser-logos/master/src/safari/safari_48x48.png" alt="Safari" width="24px" height="24px" />](http://godban.github.io/browsers-support-badges/)<br/>Safari | | ||
| ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| Latest version | Latest version | Latest version | Latest version | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest versionで問題ないか念の為確認
packages/rest/README.md
Outdated
| certAuth.pfx | [Buffer](https://nodejs.org/api/buffer.html#buffer_class_buffer) | | The [client certificate file](https://jp.cybozu.help/general/en/user/list_access/remote/webbrowser.html). Required, unless you specify `pfxFilePath`. | | ||
| certAuth.pfxFilePath | String | | The path to [client certificate file](https://jp.cybozu.help/general/en/user/list_access/remote/webbrowser.html). Required, unless you specify `pfx`. | | ||
| certAuth.password | String | | The password of client certificate. | | ||
| proxy | Object | | **This parameter is available only in Node.js environment.**<br />If you use a proxy, please specify its configuration. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest-api-clientはfalseも指定できたが、restでは不要
packages/rest/README.md
Outdated
| basicAuth.username | String | | The username of Basic authentication. | | ||
| basicAuth.password | String | | The password of Basic authentication. | | ||
| httpsAgent | Object | | **This parameter is available only in Node.js environment.**<br />The custom HTTPS agent to be used when request.<br />The agent should be compatible with [undici.Agent](https://github.com/nodejs/undici/blob/main/docs/docs/api/Agent.md). | | ||
| certAuth | Object | | **This parameter is available only in Node.js environment.**<br />**When `httpsAgent` parameter is given, this parameter is unavailable.**<br />If your Kintone environment uses [Client Certificate authentication](https://jp.cybozu.help/general/en/admin/list_security/list_access/secureaccess.html), please specify the certificate file and password. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clientCertAuth -> certAuth に変更
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clientCertAuthが正
packages/rest/README.md
Outdated
| basicAuth | Object | | If your Kintone environment uses Basic authentication, please specify its username and password. | | ||
| basicAuth.username | String | | The username of Basic authentication. | | ||
| basicAuth.password | String | | The password of Basic authentication. | | ||
| httpsAgent | Object | | **This parameter is available only in Node.js environment.**<br />The custom HTTPS agent to be used when request.<br />The agent should be compatible with [undici.Agent](https://github.com/nodejs/undici/blob/main/docs/docs/api/Agent.md). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http.Agent -> undici.Agentに変更
|
||
| Name | Type | Required | Description | | ||
|----------|:------:|:--------:|----------------------------| | ||
| type | String | Yes | Please specify "password". | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typeパラメータで認証方式を指定するようになったので追加
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
# Conflicts: # packages/rest/README.md
Why
What
How to test
Checklist
pnpm lint
andpnpm test
on the root directory.