chore(rest): remove api method #3229
Merged
+70
−352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shabaraba
requested review from
chihiro-adachi and
tasshi-me
and removed request for
a team
packages/rest/README.md
Outdated
| @@ -68,15 +68,12 @@ const client = createClient({ | |||
| }); | |||
|
|
|||
| try { | |||
| const resp = await client.GET("/k/v1/records.json", { | |||
| const resp = await client.request("get", "/k/v1/records.json", { | |||
| params: { | |||
| query: { app: "1" }, | |||
There was a problem hiding this comment.
@shabaraba
お手間でなければ "1" -> 1もついでに修正できるとありがたいです！
- query: { app: "1" },
+ query: { app: 1 },There was a problem hiding this comment.
@chihiro-adachi
すみません、直しました！
| @@ -189,7 +135,5 @@ export const iterator = <Paths extends {} = any, Media extends MediaType = any>( | |||
| init, | |||
| client.TRACE, | |||
| ), | |||
| api: (url, method, init, handleRequest, hasNext) => | |||
| createKintoneApiIteratorMethod(url, handleRequest, hasNext, init, method), | |||
| }; | |||
There was a problem hiding this comment.
@shabaraba
requestメソッドの追加は別で実装しますか？
There was a problem hiding this comment.
@chihiro-adachi
ここで実装します！
shabaraba
force-pushed
the
fix/remove-api-method
branch
from
1e6b5da to
0e0a870
Compare
shabaraba
force-pushed
the
fix/remove-api-method
branch
from
0e0a870 to
4ce4042
Compare
chihiro-adachi
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
client.api()method.What
client.api()method.client.request()instead ofclient.api().How to test
Checklist
pnpm lintandpnpm teston the root directory.