fix: use proper units in queryStatisticsForQuantity to prevent crashes #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace hardcoded "count" unit with getUnitToUse() to get the correct preferred unit for each quantity type. This fixes crashes when using queryStatisticsForQuantity with HKQuantityTypeIdentifierDistanceWalkingRunning and HKQuantityTypeIdentifierActiveEnergyBurned. Fixes #188 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 70cce7b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
|
🚀 Expo continuous deployment is ready!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getUnitToUse()inqueryStatisticsForQuantityandqueryStatisticsCollectionForQuantityHKQuantityTypeIdentifierDistanceWalkingRunningandHKQuantityTypeIdentifierActiveEnergyBurnedcaused app crashesRoot Cause
The functions were defaulting to "count" unit regardless of quantity type:
HKQuantityTypeIdentifierStepCountuses "count" → worked fineHKQuantityTypeIdentifierDistanceWalkingRunningneeds distance units (m, km, mi) → crashedHKQuantityTypeIdentifierActiveEnergyBurnedneeds energy units (kcal, kJ) → crashedSolution
Use the same approach as
queryQuantitySampleswhich already works correctly by callinggetUnitToUse()to get the appropriate unit for each quantity type.Test plan
queryStatisticsForQuantitywithHKQuantityTypeIdentifierDistanceWalkingRunning- should no longer crashqueryStatisticsForQuantitywithHKQuantityTypeIdentifierActiveEnergyBurned- should no longer crashqueryStatisticsForQuantitywithHKQuantityTypeIdentifierStepCount- should continue workingqueryStatisticsCollectionForQuantitywith various quantity types - should work correctlyFixes #188
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com