update scaffold with our latest standards #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added translations to them
martn001
reviewed
Oct 22, 2020
generator/templates/Authorisation/src/components/authorisation/LoginCard.vue
Show resolved
Hide resolved
martn001
reviewed
Oct 22, 2020
generator/templates/Authorisation/src/components/authorisation/PasswordForgottenCard.vue
Show resolved
Hide resolved
martn001
reviewed
Oct 22, 2020
martn001
reviewed
Oct 22, 2020
generator/templates/Authorisation/src/locales/nl/authorisation.json
Outdated
Show resolved
Hide resolved
martn001
reviewed
Oct 22, 2020
generator/templates/Authorisation/src/views/authorisation/InvitationAccept.vue
Outdated
Show resolved
Hide resolved
martn001
reviewed
Oct 22, 2020
generator/templates/Authorisation/src/views/authorisation/RegistrationVerify.vue
Outdated
Show resolved
Hide resolved
martn001
reviewed
Oct 22, 2020
Comment on lines
+94
to
+102
| const { response } = error; | ||
| const { status } = response; | ||
|
|
||
| this.alertType = 'error'; | ||
| if (status === 429) { | ||
| this.alertMessage = this.$t('errors.429', { minutes: getRateLimitMinutes(response) }); | ||
| } else if (status === 400) { | ||
| this.alertMessage = this.$t('authorisation.registrationVerify.errorMessage'); | ||
| } |
There was a problem hiding this comment.
Deze "error" scenario komt nu erg vaak voor. Kunnen we dit stukje code niet overal hergebruiken
There was a problem hiding this comment.
Lastige is dat het steeds net ietsjes anders is en dat lang niet ieder request een 429 heeft
Ik ben van mening dat dit per ding toch maatwerk is
martn001
reviewed
Oct 22, 2020
generator/templates/Authorisation/src/api/endpoints/authorisation/password.js
Outdated
Show resolved
Hide resolved
martn001
reviewed
Oct 22, 2020
generator/templates/Default/src/api/implementation/app/index.js
Outdated
Show resolved
Hide resolved
martn001
reviewed
Oct 22, 2020
generator/templates/Default/src/api/implementation/app/transformer.js
Outdated
Show resolved
Hide resolved
martn001
reviewed
Oct 22, 2020
generator/templates/Authorisation/src/api/endpoints/authorisation/password.js
Outdated
Show resolved
Hide resolved
martn001
reviewed
Oct 22, 2020
generator/templates/Default/src/components/crud/fields/KDateField.vue
Outdated
Show resolved
Hide resolved
martn001
reviewed
Oct 22, 2020
generator/templates/Default/src/components/crud/fields/KTimeField.vue
Outdated
Show resolved
Hide resolved
martn001
reviewed
Oct 22, 2020
….json Co-authored-by: Martijn Zentjens <martijn@kingscode.nl>
…tationAccept.vue Co-authored-by: Martijn Zentjens <martijn@kingscode.nl>
…eld.vue Co-authored-by: Martijn Zentjens <martijn@kingscode.nl>
…eld.vue Co-authored-by: Martijn Zentjens <martijn@kingscode.nl>
martn001
reviewed
Oct 22, 2020
generator/templates/Authorisation/src/api/endpoints/authorisation/register.js
Show resolved
Hide resolved
martn001
approved these changes
Oct 22, 2020
Comment on lines
3
to
4
| export default async function (email, token, password, passwordConfirmation) { | ||
| return post('registration', { |
There was a problem hiding this comment.
Suggested change
| export default async function (email, token, password, passwordConfirmation) { | |
| return post('registration', { | |
| export default async (email, token, password, passwordConfirmation) => post('registration', { email, token, password, passwordConfirmation }); |
Volgens mij werkt dit ook 😸
There was a problem hiding this comment.
Moet de rest wel weg. Ik kon niet alles selecteren omdat er verwijderde regels in zatten
| @@ -69,33 +84,33 @@ export default { | |||
| handleLogin() { | |||
| this.isLoading = true; | |||
| LoginRequest(this.form.email, this.form.password) | |||
There was a problem hiding this comment.
Async/await is wellicht leesbaarder :P?
generator/templates/Authorisation/src/components/authorisation/PasswordForgottenCard.vue
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.