fix: prevent decimal precision overflow bypass in transaction_limit - #20
Open
rafaio1 wants to merge 1 commit into
Open
fix: prevent decimal precision overflow bypass in transaction_limit#20rafaio1 wants to merge 1 commit into
rafaio1 wants to merge 1 commit into
Conversation
- Use repr() instead of str() for float-to-Decimal conversion to preserve maximum representable precision - String and Decimal inputs now correctly block amounts exceeding limits at any precision level (e.g., '1.0000000000000001' > 1) - Document that Python float inputs lose precision at assignment time; callers should use string or Decimal amounts for sub-cent accuracy - Add regression tests covering string, float, Decimal, and edge cases Fixes kindrat86#5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the decimal precision overflow bypass reported in #5.
The Bug
When a transaction amount like
1.0000000000000001was passed as a Python float, it was silently equal to1.0due to IEEE 754 float precision limits (~15-17 significant digits). This caused the engine to APPROVE transactions that should have been BLOCKED against amax_amount=1limit.The Fix
repr()instead ofstr()for float-to-Decimal conversion, preserving maximum representable precision'1.0000000000000001'> 1)Testing
Important Note for Callers
Python floats cannot represent
1.0000000000000001distinctly from1.0. For spend-control boundaries where sub-cent precision matters, pass amounts as strings or Decimal objects:Fixes #5