Fix code-cracker#774 - ignore pointer declaration

kindermannhubert · Sep 6, 2016 · 4dc4707 · 4dc4707
1 parent 160d12b
commit 4dc4707
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/CSharp/CodeCracker/Performance/MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs b/src/CSharp/CodeCracker/Performance/MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs
@@ -36,6 +36,8 @@ private static void AnalyzeNode(SyntaxNodeAnalysisContext context)
             var localDeclaration = (LocalDeclarationStatementSyntax)context.Node;
             var semanticModel = context.SemanticModel;
 
+            if (localDeclaration.GetType().IsPointer) return;
+
             if (!localDeclaration.IsConst
                 && IsDeclarationConstFriendly(localDeclaration, semanticModel)
                 && AreVariablesOnlyWrittenInsideDeclaration(localDeclaration, semanticModel) )
@@ -61,6 +63,7 @@ static bool IsDeclarationConstFriendly(LocalDeclarationStatementSyntax declarati
                 // if reference type, value is null?
                 var variableTypeName = declaration.Declaration.Type;
                 var variableType = semanticModel.GetTypeInfo(variableTypeName).ConvertedType;
+                if (variableType.TypeKind == TypeKind.Pointer) return false;
                 if (variableType.IsReferenceType && variableType.SpecialType != SpecialType.System_String && constantValue.Value != null) return false;
 
                 // nullable?

diff --git a/test/CSharp/CodeCracker.Test/Performance/MakeLocalVariablesConstWhenItIsPossibleTests.cs b/test/CSharp/CodeCracker.Test/Performance/MakeLocalVariablesConstWhenItIsPossibleTests.cs
@@ -52,6 +52,13 @@ public async Task IgnoresVariablesThatChangesValueOutsideDeclaration()
             await VerifyCSharpHasNoDiagnosticsAsync(test);
         }
 
+        public async Task IgnoresPointerDeclarations()
+        {
+            var test = @"void* value = null;".WrapInCSharpMethod();
+
+            await VerifyCSharpHasNoDiagnosticsAsync(test);
+        }
+
         [Fact]
         public async Task CreateDiagnosticsWhenAssigningAPotentialConstant()
         {