Merge main v2 into main #83

brettchaldecott · 2025-07-02T14:22:33Z

Explain your changes

Merged the changes

Checklist

I have read the “Pull requests” section in the contributing guidelines.
I agree to the terms within the code of conduct.

🛟 If you need help, consider asking for advice over in the Kinde community.

…r for each user session

…errors

… 364

add main v2 to workflow rule

…main_V2

… with unit tests

… required imports in requiremets.txt

coderabbitai

Actionable comments posted: 0

♻️ Duplicate comments (1)

kinde_fastapi/framework/fastapi_framework.py (1)

1-9: Remove duplicate and unused imports.

🧹 Nitpick comments (7)

kinde_fastapi/storage/fastapi_storage_factory.py (2)
3-3: Remove unused import.

The StorageFactory import is not used in this file and should be removed to clean up the imports.
-from kinde_sdk.core.storage.storage_factory import StorageFactory
6-6: Add proper spacing before class definition.

According to PEP8, there should be 2 blank lines before a class definition.
+
 class FastAPIStorageFactory:
kinde_fastapi/framework/fastapi_framework.py (5)
13-13: Add proper spacing before class definition.

According to PEP8, there should be 2 blank lines before a class definition.
+
 class FastAPIFramework(FrameworkInterface):
54-54: Remove duplicate docstring line.

The docstring has a duplicate line that should be removed.
-        This method initializes any necessary FastAPI components and registers Kinde routes.
118-125: Remove unused helper function.

The get_current_user function is defined but never used in the route handlers. Consider removing it to clean up the code.
-        # Helper function to get current user
-        async def get_current_user(request: Request):
-            if not self._oauth.is_authenticated(request):
-                return None
-            try:
-                return self._oauth.get_user_info(request)
-            except ValueError:
-                return None
-        
130-130: Add whitespace around operator.

Missing whitespace around the assignment operator.
-            url=await self._oauth.login()
+            url = await self._oauth.login()
189-193: Use importlib.util.find_spec for import checking.

Using importlib.util.find_spec is the recommended approach for checking module availability without importing.
         try:
-            import fastapi
+            import importlib.util
+            spec = importlib.util.find_spec("fastapi")
+            return spec is not None
-            return True
         except ImportError:
             return False

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 723947c and 1866967.

📒 Files selected for processing (2)

kinde_fastapi/framework/fastapi_framework.py (1 hunks)
kinde_fastapi/storage/fastapi_storage_factory.py (1 hunks)

🧰 Additional context used

🪛 Ruff (0.11.9)

kinde_fastapi/framework/fastapi_framework.py

1-1: typing.Dict imported but unused

Remove unused import

(F401)

1-1: typing.Any imported but unused

Remove unused import

(F401)

2-2: fastapi.Depends imported but unused

Remove unused import: fastapi.Depends

(F401)

7-7: os imported but unused

Remove unused import: os

(F401)

190-190: fastapi imported but unused; consider using importlib.util.find_spec to test for availability

(F401)

kinde_fastapi/storage/fastapi_storage_factory.py

3-3: kinde_sdk.core.storage.storage_factory.StorageFactory imported but unused

Remove unused import: kinde_sdk.core.storage.storage_factory.StorageFactory

(F401)

🪛 Flake8 (7.2.0)

kinde_fastapi/framework/fastapi_framework.py

[error] 1-1: 'typing.Dict' imported but unused

(F401)

[error] 1-1: 'typing.Any' imported but unused

(F401)

[error] 2-2: 'fastapi.Depends' imported but unused

(F401)

[error] 7-7: 'os' imported but unused

(F401)

[error] 13-13: expected 2 blank lines, found 1

(E302)

[error] 130-130: missing whitespace around operator

(E225)

[error] 190-190: 'fastapi' imported but unused

(F401)

kinde_fastapi/storage/fastapi_storage_factory.py

[error] 3-3: 'kinde_sdk.core.storage.storage_factory.StorageFactory' imported but unused

(F401)

[error] 6-6: expected 2 blank lines, found 1

(E302)

🔇 Additional comments (2)

kinde_fastapi/storage/fastapi_storage_factory.py (1)

11-23: Well-structured factory implementation.

The factory method is correctly implemented with proper type hints and documentation. The unused config parameter is appropriately documented as being kept for consistency with other storage factories.

kinde_fastapi/framework/fastapi_framework.py (1)

13-193: Comprehensive FastAPI framework implementation.

The FastAPIFramework class provides a well-structured implementation of the framework interface with proper OAuth integration, session management, and route handling. The architecture follows good separation of concerns and provides all necessary authentication flows.

- Remove import of generate_random_string, base64_url_encode, and generate_pkce_pair helpers - Keep only storage and framework related imports that are actually used

- Remove duplicate import statement for FeatureFlagsApi - Clean up import section to avoid redundancy

- Remove unused warnings import - Remove duplicate pydantic Field and StrictStr imports - Remove duplicate typing_extensions Annotated import - Keep only necessary imports to reduce code clutter

- Restore original imports in callbacks_api.py including duplicate imports - Restore original imports in connections_api.py - Ensure generated code matches OpenAPI specification output - Maintain consistency with auto-generated API client code

- Remove extra space before equals sign in logger parameter default value - Follow PEP 8 style guidelines for function parameter formatting

coderabbitai

Actionable comments posted: 0

♻️ Duplicate comments (11)

kinde_sdk/management/api/connections_api.py (1)
15-15: Remove unused import

The warnings module is imported but never used in the code.
-import warnings
kinde_sdk/auth/oauth.py (5)

5-15: Remove unused imports.

This issue has been previously identified and specific imports to remove have been listed.

135-144: Convert debug logging to appropriate level.

This debug logging issue has been previously identified with specific recommendations to change from warning to debug level.

486-486: Convert debug logging to appropriate level.

This debug logging issue has been previously identified.

503-505: Use proper exception chaining.

This exception chaining issue has been previously identified with specific fix provided.

568-571: Convert debug logging to appropriate level.

This debug logging issue has been previously identified.

kinde_sdk/core/helpers.py (5)

40-69: Remove unnecessary async keyword from synchronous function.

This issue has been previously identified with the recommendation to remove the async keyword.

71-121: Remove unnecessary async keyword or use async HTTP client.

This issue has been previously identified with specific recommendations.

150-153: Use proper exception chaining for better debugging.

This exception chaining issue has been previously identified with specific fix provided.

332-332: Remove spaces around default parameter equals to comply with PEP 8.

This PEP 8 violation has been previously identified with specific functions listed.

503-507: Simplify role checking logic using any().

This optimization has been previously identified with the specific any() replacement provided.

🧹 Nitpick comments (4)

kinde_sdk/auth/oauth.py (4)
160-160: Remove unnecessary f-string prefix.

The f-string has no placeholders and should be a regular string for better performance.
-        self._logger.warning(f"Retrieve the user id")
+        self._logger.warning("Retrieve the user id")
172-172: Remove unnecessary f-string prefix.

The f-string has no placeholders and should be a regular string for better performance.
-        self._logger.warning(f"Get the claims from the token manager")
+        self._logger.warning("Get the claims from the token manager")
176-176: Remove unnecessary f-string prefix.

The f-string has no placeholders and should be a regular string for better performance.
-        self._logger.warning(f"Return the claims")
+        self._logger.warning("Return the claims")
184-184: Use underscore for unused exception variable.

The exception variable is not used and should be replaced with underscore to follow Python conventions.
-        except Exception as e:
+        except Exception:

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a330e7f and 3db423b.

📒 Files selected for processing (3)

kinde_sdk/auth/oauth.py (1 hunks)
kinde_sdk/core/helpers.py (1 hunks)
kinde_sdk/management/api/connections_api.py (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

kinde_sdk/auth/oauth.py (1)

Learnt from: brettchaldecott
PR: kinde-oss/kinde-python-sdk#83
File: kinde_flask/examples/example_app.py:25-44
Timestamp: 2025-07-03T09:38:46.133Z
Learning: The kinde_flask framework automatically creates and registers standard OAuth routes (/login, /logout, /callback, /register, /user) at runtime when the OAuth instance is initialized with a Flask app. These routes do not need to be manually defined in application code.

🧬 Code Graph Analysis (1)

kinde_sdk/management/api/connections_api.py (5)

kinde_sdk/model/success_response.py (1)

SuccessResponse (27-89)

kinde_sdk/api_client.py (1)

ApiResponse (802-818)

kinde_sdk/management/api_client.py (4)

response_deserialize (286-334)

select_header_accept (574-587)

select_header_content_type (589-602)

param_serialize (142-248)

test/test_paths/__init__.py (1)

response (53-71)

kinde_sdk/exceptions.py (1)

body (115-118)

🪛 Ruff (0.11.9)

kinde_sdk/auth/oauth.py

5-5: typing.List imported but unused

Remove unused import

(F401)

5-5: typing.Tuple imported but unused

Remove unused import

(F401)

5-5: typing.Union imported but unused

Remove unused import

(F401)

6-6: urllib.parse.urlparse imported but unused

Remove unused import

(F401)

6-6: urllib.parse.quote imported but unused

Remove unused import

(F401)

13-13: .enums.GrantType imported but unused

Remove unused import: .enums.GrantType

(F401)

15-15: kinde_sdk.core.helpers.base64_url_encode imported but unused

Remove unused import: kinde_sdk.core.helpers.base64_url_encode

(F401)

160-160: f-string without any placeholders

Remove extraneous f prefix

(F541)

172-172: f-string without any placeholders

Remove extraneous f prefix

(F541)

176-176: f-string without any placeholders

Remove extraneous f prefix

(F541)

184-184: Local variable e is assigned to but never used

Remove assignment to unused variable e

(F841)

505-505: Within an except clause, raise exceptions with raise ... from err or raise ... from None to distinguish them from errors in exception handling

(B904)

kinde_sdk/core/helpers.py

153-153: Within an except clause, raise exceptions with raise ... from err or raise ... from None to distinguish them from errors in exception handling

(B904)

503-507: Use return any(role.get("code") == role_code for role in roles) instead of for loop

Replace with return any(role.get("code") == role_code for role in roles)

(SIM110)

kinde_sdk/management/api/connections_api.py

15-15: warnings imported but unused

Remove unused import: warnings

(F401)

🪛 GitHub Check: codecov/patch

kinde_sdk/auth/oauth.py

[warning] 60-60: kinde_sdk/auth/oauth.py#L60
Added line #L60 was not covered by tests

[warning] 67-68: kinde_sdk/auth/oauth.py#L67-L68
Added lines #L67 - L68 were not covered by tests

[warning] 78-78: kinde_sdk/auth/oauth.py#L78
Added line #L78 was not covered by tests

[warning] 101-101: kinde_sdk/auth/oauth.py#L101
Added line #L101 was not covered by tests

[warning] 104-104: kinde_sdk/auth/oauth.py#L104
Added line #L104 was not covered by tests

[warning] 110-110: kinde_sdk/auth/oauth.py#L110
Added line #L110 was not covered by tests

[warning] 113-113: kinde_sdk/auth/oauth.py#L113
Added line #L113 was not covered by tests

[warning] 116-116: kinde_sdk/auth/oauth.py#L116
Added line #L116 was not covered by tests

[warning] 119-119: kinde_sdk/auth/oauth.py#L119
Added line #L119 was not covered by tests

[warning] 122-122: kinde_sdk/auth/oauth.py#L122
Added line #L122 was not covered by tests

[warning] 135-137: kinde_sdk/auth/oauth.py#L135-L137
Added lines #L135 - L137 were not covered by tests

[warning] 139-140: kinde_sdk/auth/oauth.py#L139-L140
Added lines #L139 - L140 were not covered by tests

[warning] 143-144: kinde_sdk/auth/oauth.py#L143-L144
Added lines #L143 - L144 were not covered by tests

[warning] 160-161: kinde_sdk/auth/oauth.py#L160-L161
Added lines #L160 - L161 were not covered by tests

[warning] 163-163: kinde_sdk/auth/oauth.py#L163
Added line #L163 was not covered by tests

[warning] 166-167: kinde_sdk/auth/oauth.py#L166-L167
Added lines #L166 - L167 were not covered by tests

[warning] 169-169: kinde_sdk/auth/oauth.py#L169
Added line #L169 was not covered by tests

[warning] 172-173: kinde_sdk/auth/oauth.py#L172-L173
Added lines #L172 - L173 were not covered by tests

[warning] 175-177: kinde_sdk/auth/oauth.py#L175-L177
Added lines #L175 - L177 were not covered by tests

[warning] 184-188: kinde_sdk/auth/oauth.py#L184-L188
Added lines #L184 - L188 were not covered by tests

[warning] 212-215: kinde_sdk/auth/oauth.py#L212-L215
Added lines #L212 - L215 were not covered by tests

[warning] 235-235: kinde_sdk/auth/oauth.py#L235
Added line #L235 was not covered by tests

[warning] 238-238: kinde_sdk/auth/oauth.py#L238
Added line #L238 was not covered by tests

[warning] 262-262: kinde_sdk/auth/oauth.py#L262
Added line #L262 was not covered by tests

[warning] 271-271: kinde_sdk/auth/oauth.py#L271
Added line #L271 was not covered by tests

[warning] 279-279: kinde_sdk/auth/oauth.py#L279
Added line #L279 was not covered by tests

🪛 Flake8 (7.2.0)

kinde_sdk/auth/oauth.py

[error] 5-5: 'typing.List' imported but unused

(F401)

[error] 5-5: 'typing.Tuple' imported but unused

(F401)

[error] 5-5: 'typing.Union' imported but unused

(F401)

[error] 6-6: 'urllib.parse.urlparse' imported but unused

(F401)

[error] 6-6: 'urllib.parse.quote' imported but unused

(F401)

[error] 13-13: '.enums.GrantType' imported but unused

(F401)

[error] 15-15: 'kinde_sdk.core.helpers.base64_url_encode' imported but unused

(F401)

[error] 23-23: expected 2 blank lines, found 1

(E302)

[error] 160-160: f-string is missing placeholders

(F541)

[error] 172-172: f-string is missing placeholders

(F541)

[error] 176-176: f-string is missing placeholders

(F541)

[error] 184-184: local variable 'e' is assigned to but never used

(F841)

[error] 278-278: continuation line under-indented for visual indent

(E128)

kinde_sdk/core/helpers.py

[error] 13-13: expected 2 blank lines, found 1

(E302)

[error] 25-25: expected 2 blank lines, found 1

(E302)

[error] 40-40: expected 2 blank lines, found 1

(E302)

[error] 71-71: expected 2 blank lines, found 1

(E302)

[error] 124-124: expected 2 blank lines, found 1

(E302)

[error] 155-155: expected 2 blank lines, found 1

(E302)

[error] 172-172: expected 2 blank lines, found 1

(E302)

[error] 225-225: expected 2 blank lines, found 1

(E302)

[error] 278-278: expected 2 blank lines, found 1

(E302)

[error] 332-332: expected 2 blank lines, found 1

(E302)

[error] 397-397: expected 2 blank lines, found 1

(E302)

[error] 397-397: unexpected spaces around keyword / parameter equals

(E251)

[error] 397-397: unexpected spaces around keyword / parameter equals

(E251)

[error] 423-423: expected 2 blank lines, found 1

(E302)

[error] 423-423: unexpected spaces around keyword / parameter equals

(E251)

[error] 423-423: unexpected spaces around keyword / parameter equals

(E251)

[error] 484-484: expected 2 blank lines, found 1

(E302)

[error] 484-484: unexpected spaces around keyword / parameter equals

(E251)

[error] 484-484: unexpected spaces around keyword / parameter equals

(E251)

[error] 514-514: expected 2 blank lines, found 1

(E302)

[error] 514-514: unexpected spaces around keyword / parameter equals

(E251)

[error] 514-514: unexpected spaces around keyword / parameter equals

(E251)

[error] 566-566: expected 2 blank lines, found 1

(E302)

[error] 588-588: expected 2 blank lines, found 1

(E302)

[error] 610-610: expected 2 blank lines, found 1

(E302)

[error] 619-619: expected 2 blank lines, found 1

(E302)

[error] 631-631: expected 2 blank lines, found 1

(E302)

[error] 640-640: expected 2 blank lines, found 1

(E302)

[error] 656-656: expected 2 blank lines, found 1

(E302)

[error] 670-670: expected 2 blank lines, found 1

(E302)

[error] 684-684: expected 2 blank lines, found 1

(E302)

kinde_sdk/management/api/connections_api.py

[error] 15-15: 'warnings' imported but unused

(F401)

[error] 46-46: too many blank lines (2)

(E303)

[error] 89-89: at least two spaces before inline comment

(E261)

[error] 116-116: too many blank lines (2)

(E303)

[error] 159-159: at least two spaces before inline comment

(E261)

[error] 186-186: too many blank lines (2)

(E303)

[error] 229-229: at least two spaces before inline comment

(E261)

[error] 239-239: local variable '_response_types_map' is assigned to but never used

(F841)

[error] 252-252: too many blank lines (2)

(E303)

[error] 284-284: too many blank lines (2)

(E303)

[error] 329-329: too many blank lines (4)

(E303)

[error] 372-372: at least two spaces before inline comment

(E261)

[error] 400-400: too many blank lines (2)

(E303)

[error] 443-443: at least two spaces before inline comment

(E261)

[error] 471-471: too many blank lines (2)

(E303)

[error] 514-514: at least two spaces before inline comment

(E261)

[error] 524-524: local variable '_response_types_map' is assigned to but never used

(F841)

[error] 538-538: too many blank lines (2)

(E303)

[error] 570-570: too many blank lines (2)

(E303)

[error] 579-579: too many blank lines (2)

(E303)

[error] 602-602: too many blank lines (4)

(E303)

[error] 645-645: at least two spaces before inline comment

(E261)

[error] 672-672: too many blank lines (2)

(E303)

[error] 715-715: at least two spaces before inline comment

(E261)

[error] 742-742: too many blank lines (2)

(E303)

[error] 785-785: at least two spaces before inline comment

(E261)

[error] 795-795: local variable '_response_types_map' is assigned to but never used

(F841)

[error] 808-808: too many blank lines (2)

(E303)

[error] 840-840: too many blank lines (2)

(E303)

[error] 849-849: too many blank lines (2)

(E303)

[error] 872-872: too many blank lines (4)

(E303)

[error] 924-924: at least two spaces before inline comment

(E261)

[error] 954-954: too many blank lines (2)

(E303)

[error] 1006-1006: at least two spaces before inline comment

(E261)

[error] 1036-1036: too many blank lines (2)

(E303)

[error] 1088-1088: at least two spaces before inline comment

(E261)

[error] 1101-1101: local variable '_response_types_map' is assigned to but never used

(F841)

[error] 1114-1114: too many blank lines (2)

(E303)

[error] 1163-1163: too many blank lines (2)

(E303)

[error] 1173-1173: too many blank lines (2)

(E303)

[error] 1196-1196: too many blank lines (4)

(E303)

[error] 1242-1242: at least two spaces before inline comment

(E261)

[error] 1271-1271: too many blank lines (2)

(E303)

[error] 1317-1317: at least two spaces before inline comment

(E261)

[error] 1346-1346: too many blank lines (2)

(E303)

[error] 1392-1392: at least two spaces before inline comment

(E261)

[error] 1403-1403: local variable '_response_types_map' is assigned to but never used

(F841)

[error] 1417-1417: too many blank lines (2)

(E303)

[error] 1452-1452: too many blank lines (2)

(E303)

[error] 1497-1497: too many blank lines (4)

(E303)

[error] 1543-1543: at least two spaces before inline comment

(E261)

[error] 1572-1572: too many blank lines (2)

(E303)

[error] 1618-1618: at least two spaces before inline comment

(E261)

[error] 1647-1647: too many blank lines (2)

(E303)

[error] 1693-1693: at least two spaces before inline comment

(E261)

[error] 1704-1704: local variable '_response_types_map' is assigned to but never used

(F841)

[error] 1718-1718: too many blank lines (2)

(E303)

[error] 1753-1753: too many blank lines (2)

(E303)

🔇 Additional comments (4)

kinde_sdk/management/api/connections_api.py (1)

33-1796: LGTM! Well-structured API client implementation.

The ConnectionsApi class follows excellent patterns for an auto-generated API client:

Comprehensive CRUD operations with proper HTTP methods (POST, DELETE, GET, PUT, PATCH)

Three method variants per operation: standard deserialized response, detailed HTTP info, and raw response

Robust input validation using Pydantic's @validate_call decorator

Consistent authentication using kindeBearerAuth across all endpoints

Proper error handling with comprehensive response type mapping

Clean request serialization with dedicated methods for each operation

The implementation provides excellent flexibility for different use cases while maintaining consistency and type safety.

kinde_sdk/auth/oauth.py (1)

23-630: Excellent OAuth 2.0 implementation with comprehensive security features.

This OAuth class demonstrates solid architecture with:

Complete PKCE flow implementation for enhanced security

Proper state and nonce handling to prevent CSRF attacks

Comprehensive error handling with specific exception types

Framework-agnostic design supporting multiple web frameworks

Extensive OAuth parameter support for various authentication flows

Clean separation of concerns between authentication, session management, and storage

The implementation follows OAuth 2.0 and OpenID Connect best practices while providing a flexible, extensible foundation for the SDK.

kinde_sdk/core/helpers.py (2)

172-564: Excellent error handling patterns throughout API helper functions.

The helper functions demonstrate consistent, robust error handling with:

Proper exception type separation (ValueError for token issues, RequestException for network issues)

Detailed error message extraction from API responses including error codes and descriptions

Optional logger parameters providing flexibility while maintaining good observability

Graceful fallbacks for non-critical operations like feature flags

Clear error propagation allowing calling code to handle failures appropriately

This pattern creates a reliable foundation for API interactions throughout the SDK.

13-69: Solid cryptographic utilities following security best practices.

The cryptographic functions demonstrate good security practices:

Using secrets.token_urlsafe() for cryptographically secure random string generation

Proper PKCE implementation following RFC 7636 with SHA-256 hashing

Standard-compliant base64url encoding without padding

Appropriate error handling with fallback mechanisms

These utilities provide a secure foundation for OAuth 2.0 flows and token operations.

- Change verbose logging statements from warning to debug level - Reduce log noise in production by using appropriate log levels - Keep debug information available for troubleshooting when needed - Affects authentication flow logging in is_authenticated() and get_user_info() methods

coderabbitai

Actionable comments posted: 0

♻️ Duplicate comments (6)

kinde_sdk/auth/oauth.py (6)

5-15: Clean up unused imports to improve code quality.

Several imports are unused and should be removed based on static analysis.

Apply this diff to remove unused imports:

-from typing import Any, Dict, List, Optional, Tuple, Union
+from typing import Any, Dict, Optional
-from urllib.parse import urlencode, urlparse, quote
+from urllib.parse import urlencode

-from .enums import GrantType, IssuerRouteTypes, PromptTypes
+from .enums import IssuerRouteTypes, PromptTypes
-from kinde_sdk.core.helpers import generate_random_string, base64_url_encode, generate_pkce_pair, get_user_details as helper_get_user_details
+from kinde_sdk.core.helpers import generate_random_string, generate_pkce_pair, get_user_details as helper_get_user_details

135-144: Convert debug logging to appropriate level.

The logging statements are using warning level for debug information.

Apply this diff to use appropriate logging levels:

-        self._logger.debug(f"self._framework: {self._framework}")
+        self._logger.debug(f"self._framework: {self._framework}")
         user_id = self._framework.get_user_id()
-        self._logger.debug(f"user_id: {user_id}")
+        self._logger.debug(f"user_id: {user_id}")
         if not user_id:
-            self._logger.debug("No user ID found in session")
+            self._logger.debug("No user ID found in session")
             return False
             
         # Check authentication using session manager
-        self._logger.debug(f"self._session_manager: {self._session_manager}")
+        self._logger.debug(f"self._session_manager: {self._session_manager}")

486-486: Convert debug logging to appropriate level.

This appears to be debug logging that should use debug level instead of warning.

-            self._logger.warning(f"stored_state: {stored_state}, state: {state}")
+            self._logger.debug(f"stored_state: {stored_state}, state: {state}")

503-505: Use proper exception chaining.

When re-raising exceptions, use from e to maintain the exception chain for better debugging.

         except Exception as e:
             self._logger.error(f"Token exchange failed: {str(e)}")
-            raise KindeTokenException(f"Failed to exchange code for tokens: {str(e)}")
+            raise KindeTokenException(f"Failed to exchange code for tokens: {str(e)}") from e

568-572: Convert debug logging to appropriate level.

These warning logs appear to be for debugging purposes and should use the appropriate log level.

-        self._logger.warning(f"[Exchange code for tokens] [{self.token_url}] [{data}]")
+        self._logger.debug(f"[Exchange code for tokens] [{self.token_url}] [{data}]")

         response = requests.post(self.token_url, data=data)
-        self._logger.warning(f"[Exchange code for tokens] [{response.status_code}] [{response.text}]")
+        self._logger.debug(f"[Exchange code for tokens] [{response.status_code}] [{response.text}]")

628-630: Use proper exception chaining.

Similar to the previous exception handling issue, use from e for proper exception chaining.

         except Exception as e:
             self._logger.error(f"Error retrieving tokens: {str(e)}")
-            raise ValueError(f"Failed to retrieve tokens: {str(e)}")
+            raise ValueError(f"Failed to retrieve tokens: {str(e)}") from e

🧹 Nitpick comments (3)

kinde_sdk/auth/oauth.py (3)

160-177: Remove unnecessary f-string prefixes and improve logging.

Several f-strings don't have placeholders and logging could be improved.

Apply this diff to clean up the logging:

-        self._logger.debug(f"Retrieve the user id")
+        self._logger.debug("Retrieve the user id")
         user_id = self._framework.get_user_id()
         if not user_id:
             raise KindeConfigurationException("No user ID found in session")
             
         # Get token manager for the user
         self._logger.debug(f"User id: {user_id} retrieve the token for the user id")
         token_manager = self._session_manager.get_token_manager(user_id)
         if not token_manager:
             raise KindeConfigurationException("No token manager found for user")
             
         # Get claims from token manager
-        self._logger.debug(f"Get the claims from the token manager")
+        self._logger.debug("Get the claims from the token manager")
         claims = token_manager.get_claims()
         if not claims:
             raise KindeConfigurationException("No user claims found")
-        self._logger.debug(f"Return the claims")
+        self._logger.debug("Return the claims")
         return claims

184-188: Remove unused exception variable.

The exception variable e is assigned but never used in the except block.

Apply this diff to remove the unused variable:

-        except Exception as e:
+        except Exception:
             self.auth_url = f"{self.host}/oauth2/auth"
             self.token_url = f"{self.host}/oauth2/token"
             self.logout_url = f"{self.host}/logout"
             self.userinfo_url = f"{self.host}/oauth2/userinfo"

23-36: Consider adding type hints for better code documentation.

The app parameter lacks specific typing, which could improve IDE support and code clarity.

Consider adding a more specific type hint or using a protocol for the app parameter:

 class OAuth:
     def __init__(
         self,
         client_id: Optional[str] = None,
         client_secret: Optional[str] = None,
         redirect_uri: Optional[str] = None,
         config_file: Optional[str] = None,
         storage_config: Optional[Dict[str, Any]] = None,
         framework: Optional[str] = None,
         audience: Optional[str] = None,
         host: Optional[str] = None,
         state: Optional[str] = None,
-        app: Optional[Any] = None,
+        app: Optional[Any] = None,  # Consider: Union[Flask, FastAPI, Any] or create a Protocol
     ):

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3db423b and b52a07c.

📒 Files selected for processing (1)

kinde_sdk/auth/oauth.py (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

kinde_sdk/auth/oauth.py (1)

Learnt from: brettchaldecott
PR: kinde-oss/kinde-python-sdk#83
File: kinde_flask/examples/example_app.py:25-44
Timestamp: 2025-07-03T09:38:46.133Z
Learning: The kinde_flask framework automatically creates and registers standard OAuth routes (/login, /logout, /callback, /register, /user) at runtime when the OAuth instance is initialized with a Flask app. These routes do not need to be manually defined in application code.