fix: setup get user object + to ts

[peterphanouvong]

Explain your changes

• fix bug with getUserObject
• change file to TS
  Suppose there is a related issue with enough detail for a reviewer to understand your changes fully. In that case, you can omit an explanation and instead include either “Fixes #XX” or “Updates #XX” where “XX” is the issue number.

Checklist

• I have read the “Pull requests” section in the contributing guidelines.
• I agree to the terms within the code of conduct.

🛟 If you need help, consider asking for advice over in the Kinde community.

[coderabbitai]

Walkthrough

The changes involve a significant modification to the setup function in src/handlers/setup.ts, specifically in the way user properties are handled. The previous implementation retrieved user properties from claims using the getClaimValue method, while the updated version directly passes idToken and accessToken to the generateUserObject function, indicating a shift in how user information is sourced.

Changes

File Path	Change Summary
src/handlers/setup.ts	Modified the setup function to remove retrieval of user properties and instead pass idToken and accessToken directly to generateUserObject. The function signature remains unchanged.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4195dd4 and fdf94de.

Files selected for processing (1)

• src/handlers/setup.ts (3 hunks)

Additional comments not posted (2)

src/handlers/setup.ts (2)

2-2: LGTM!

The import statement is correct and necessary for the type casting in the generateUserObject function.

The code changes are approved.

---

73-76: LGTM! But verify the function usage in the codebase.

The changes streamline the user object creation process by directly using idToken and accessToken. Ensure that the generateUserObject function can handle the tokens correctly and that the tokens contain all necessary information.

The code changes are approved.

Run the following script to verify the function usage:

Verification successful

---

Function usage is consistent and correct across the codebase.

The generateUserObject function is used with the new signature in multiple locations, including test files, ensuring its correct integration and behavior. No issues were found with the usage of this function.

• tests/frontend/utils.test.ts: Multiple test cases verify the function's behavior.
• src/session/getUser.ts: Function used with the new signature.
• src/handlers/setup.ts: Function used with the new signature.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `generateUserObject` match the new signature.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type typescript -A 5 $'generateUserObject'

Length of output: 81

---

Script:

#!/bin/bash
# Description: Verify all function calls to `generateUserObject` match the new signature.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type ts -A 5 $'generateUserObject'

Length of output: 4179