Skip to content

Conversation

@victoreronmosele
Copy link
Member

@victoreronmosele victoreronmosele commented Dec 20, 2025

Description (required)

This PR fixes the meta-data samples in the Android SDK set up.

The meta-data entries were missing a quote for the android:name property and this would cause an error if someone copied and pasted the sample.

Before After
Screenshot 2025-12-20 at 16 04 53 Screenshot 2025-12-20 at 16 03 51
Screenshot 2025-12-20 at 16 04 28 Screenshot 2025-12-20 at 16 04 10

Summary by CodeRabbit

  • Bug Fixes

    • Resolved malformed meta-data entries in Android SDK code examples.
  • Documentation

    • Improved Android SDK documentation with corrected code block formatting and standards compliance.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 20, 2025

Walkthrough

Fixed malformed AndroidManifest meta-data entries in Android SDK documentation by properly closing string literals and corrected trailing newlines in code blocks to ensure valid XML examples.

Changes

Cohort / File(s) Summary
Documentation fixes
src/content/docs/developer-tools/sdks/native/android-sdk.mdx
Corrected unclosed string literals in AndroidManifest meta-data entries (android:name attributes for au.kinde.domain and au.kinde.clientId); added trailing newlines after code block fences

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single documentation file with straightforward syntax corrections
  • No logic or functional changes
  • Fix addresses malformed XML in code examples only

Poem

A rabbit hops through docs so grand,
Found XML that couldn't stand—
Fixed the quotes, aligned the lines,
Now the manifest code shines! ✨🐰

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main fix: correcting malformed meta-data samples in Android SDK documentation by closing unclosed string literals.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/meta-data-android-samples

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e4180c and a8697be.

📒 Files selected for processing (1)
  • src/content/docs/developer-tools/sdks/native/android-sdk.mdx (3 hunks)
🔇 Additional comments (3)
src/content/docs/developer-tools/sdks/native/android-sdk.mdx (3)

94-108: LGTM! Critical syntax fix for AndroidManifest configuration.

The properly closed string literals in the android:name attributes ensure valid XML syntax. This fix prevents build errors when developers copy-paste these configuration examples.


112-126: LGTM! Consistent fix applied to the configuration example.

The corrections mirror the first example block, ensuring both the template and concrete examples demonstrate valid XML syntax.


668-668: Good practice: Trailing newline added.

Adding a newline at the end of the file aligns with POSIX standards and common markdown formatting conventions.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the sdk label Dec 20, 2025
@victoreronmosele victoreronmosele changed the title fix: fix meta-data samples in Android SDK docs fix: correct meta-data samples in Android SDK docs Dec 20, 2025
@cloudflare-workers-and-pages
Copy link

Deploying kinde-docs-preview with  Cloudflare Pages  Cloudflare Pages

Latest commit: a8697be
Status: ✅  Deploy successful!
Preview URL: https://427de8a4.kinde-docs-preview.pages.dev
Branch Preview URL: https://fix-meta-data-android-sample.kinde-docs-preview.pages.dev

View logs

@victoreronmosele victoreronmosele marked this pull request as ready for review December 20, 2025 16:33
@victoreronmosele victoreronmosele requested a review from a team as a code owner December 20, 2025 16:33
@tamalchowdhury
Copy link
Collaborator

This change has already covered in another PR #632

@victoreronmosele victoreronmosele deleted the fix/meta-data-android-samples branch December 23, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants