Feat/microsoft365 connected app #322
Conversation
|
Warning Rate limit exceeded@clairekinde11 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 36 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughA new documentation page has been added to guide the integration of Kinde with Microsoft 365. The page details the prerequisites, including a Microsoft Azure account and a machine-to-machine application with an end-user. It provides a structured walkthrough for registering a Microsoft app, adding calendar scopes, generating a client secret, and finalizing the configuration in Kinde. The document also includes visual aids and warnings about the current scope validations. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant A as Microsoft Azure
participant K as Kinde
U->>A: Sign in & navigate to app registration
A->>U: Display registration form
U->>A: Enter app details & add calendar scopes
A->>U: Generate client secret and set permissions
U->>K: Update configuration with app info
K->>U: Confirm connection established
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying kinde-docs-previews with
|
| Latest commit: |
46b7d0b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://21e5b926.kinde-docs-previews.pages.dev |
| Branch Preview URL: | https://feat-microsoft365-connected.kinde-docs-previews.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/content/docs/integrate/connected-apps/microsoft-365-connected-app.mdx (2)
25-38: Register a Microsoft App SectionThe step-by-step instructions for registering a Microsoft app are well structured. A few stylistic improvements are suggested:
- Line 30: The phrase “in the left side menu” should be changed to “on the left side menu” for better natural language usage.
- Line 35: The sentence containing “your custom domain if you use one, otherwise this is your Kinde domain” can be rephrased for clarity. For example, using a semicolon or splitting into two sentences would improve readability.
- Line 37: Adding a comma before “or” can smooth out the sentence structure.
Suggested diff:
-2. Navigate to **Entra ID**. You can do this from links on the main screen or in the left side menu. +2. Navigate to **Entra ID**. You can do this from links on the main screen or on the left side menu.-7. Enter the **Provider to Kinde callback URL** from the Kinde connected app. For example, `https://app.{yourdomain}/connected_apps/callback`. {yourdomain} is your custom domain if you use one, otherwise this is your Kinde domain. +7. Enter the **Provider to Kinde callback URL** from the Kinde connected app. For example, `https://app.{yourdomain}/connected_apps/callback`. {yourdomain} is your custom domain if you use one; if not, use your Kinde domain.-9. Copy the **Application (client) ID** and paste it in a text file or somewhere you can easily access it again. You’ll use this as the **Client ID** for the connected app in Kinde. +9. Copy the **Application (client) ID**, and paste it in a text file or somewhere you can easily access it again. You’ll use this as the **Client ID** for the connected app in Kinde.🧰 Tools
🪛 LanguageTool
[grammar] ~30-~30: In this case, the usual preposition with “side” is “on”, not “in”. Did you mean “on the left side”?
Context: ...o this from links on the main screen or in the left side menu. 3. Select **Add+ > App registrati...(IN_ON_THE_RIGHT_HAND_SIDE)
[typographical] ~35-~35: The word “otherwise” is an adverb that can’t be used like a conjunction, and therefore needs to be separated from the sentence.
Context: ...omain} is your custom domain if you use one, otherwise this is your Kinde domain. 8. Select **...(THUS_SENTENCE)
[uncategorized] ~37-~37: Use a comma before ‘or’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...client) ID** and paste it in a text file or somewhere you can easily access it agai...(COMMA_COMPOUND_SENTENCE)
39-63: Add Calendar Scopes and Generate a Secret SectionThis section is clearly divided into tasks with an informative warning block to indicate that only calendar scopes have been tested. The steps are methodical and easy to follow. A minor punctuation suggestion is noted for line 59:
- Insert a comma before “or” in the instruction regarding copying the secret value to enhance clarity.
Suggested diff:
-3. Copy the value in the **Value** column and paste it in a text file or somewhere you can easily access it again. Make sure you copy from the **Value** column, not the **Secret ID** column. +3. Copy the value in the **Value** column, and paste it in a text file or somewhere you can easily access it again. Make sure you copy from the **Value** column, not the **Secret ID** column.🧰 Tools
🪛 LanguageTool
[uncategorized] ~59-~59: Use a comma before ‘or’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...lue** column and paste it in a text file or somewhere you can easily access it agai...(COMMA_COMPOUND_SENTENCE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/content/docs/integrate/connected-apps/microsoft-365-connected-app.mdx(1 hunks)
🧰 Additional context used
🪛 LanguageTool
src/content/docs/integrate/connected-apps/microsoft-365-connected-app.mdx
[grammar] ~30-~30: In this case, the usual preposition with “side” is “on”, not “in”. Did you mean “on the left side”?
Context: ...o this from links on the main screen or in the left side menu. 3. Select **Add+ > App registrati...
(IN_ON_THE_RIGHT_HAND_SIDE)
[typographical] ~35-~35: The word “otherwise” is an adverb that can’t be used like a conjunction, and therefore needs to be separated from the sentence.
Context: ...omain} is your custom domain if you use one, otherwise this is your Kinde domain. 8. Select **...
(THUS_SENTENCE)
[uncategorized] ~37-~37: Use a comma before ‘or’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...client) ID** and paste it in a text file or somewhere you can easily access it agai...
(COMMA_COMPOUND_SENTENCE)
[uncategorized] ~59-~59: Use a comma before ‘or’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...lue** column and paste it in a text file or somewhere you can easily access it agai...
(COMMA_COMPOUND_SENTENCE)
🔇 Additional comments (4)
src/content/docs/integrate/connected-apps/microsoft-365-connected-app.mdx (4)
1-11: Metadata Header ReviewThe YAML front matter is well formatted and properly includes the new page details such as
page_id,title,sidebar.order, andrelatedArticles. Ensure that the related article IDs are current and valid.
13-16: Introduction SectionThe introductory lines clearly inform the reader about the new connection capability between Kinde and Microsoft 365. The messaging is direct and sets the context for the detailed steps that follow.
17-24: Prerequisites ("Before you begin") SectionThe bullet-point list for prerequisites is clear, concise, and logically organized. Verifying that the linked documentation for the machine-to-machine application and end-user creation is up to date will ensure a smooth user experience.
64-68: Final Configuration SectionThe final section concisely instructs users on the final steps needed to complete the connection in Kinde. The call-to-action linking to Step 3 of the connected app configuration is evident and direct.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
src/content/docs/integrate/connected-apps/microsoft-365-connected-app.mdx (4)
29-30: Refine Navigation Instruction Preposition
In step 2 ("Navigate to Entra ID. You can do this from links on the main screen or in the left side menu."), consider changing "in the left side menu" to "on the left side menu" for improved clarity.-... from links on the main screen or in the left side menu. +... from links on the main screen or on the left side menu.🧰 Tools
🪛 LanguageTool
[grammar] ~30-~30: In this case, the usual preposition with “side” is “on”, not “in”. Did you mean “on the left side”?
Context: ...o this from links on the main screen or in the left side menu. 3. Select **Add+ > App registrati...(IN_ON_THE_RIGHT_HAND_SIDE)
35-35: Clarify Domain Selection Wording
In step 7, the sentence "… is your custom domain if you use one, otherwise this is your Kinde domain." could be rephrased for better clarity. For example, consider:"… is your custom domain if available; otherwise, use your Kinde domain."
-<yourdomain> is your custom domain if you use one, otherwise this is your Kinde domain. +<yourdomain> is your custom domain if available; otherwise, use your Kinde domain.🧰 Tools
🪛 LanguageTool
[typographical] ~35-~35: The word “otherwise” is an adverb that can’t be used like a conjunction, and therefore needs to be separated from the sentence.
Context: ...omain> is your custom domain if you use one, otherwise this is your Kinde domain. 8. Select **...(THUS_SENTENCE)
37-37: Punctuate for Readability in ID Copy Instruction
On line 37, adding a comma before "or" improves readability.-Copy the **Application (client) ID** and paste it in a text file or somewhere you can easily access it again. +Copy the **Application (client) ID**, and paste it in a text file or somewhere you can easily access it again.🧰 Tools
🪛 LanguageTool
[uncategorized] ~37-~37: Use a comma before ‘or’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...client) ID** and paste it in a text file or somewhere you can easily access it agai...(COMMA_COMPOUND_SENTENCE)
59-59: Improve Clarity in Secret Copy Instruction
On line 59, consider adding a comma before "or" for better clarity when instructing users to copy the value from the Value column.-Copy the value in the **Value** column and paste it in a text file or somewhere you can easily access it again. +Copy the value in the **Value** column, and paste it in a text file or somewhere you can easily access it again.🧰 Tools
🪛 LanguageTool
[uncategorized] ~59-~59: Use a comma before ‘or’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...lue** column and paste it in a text file or somewhere you can easily access it agai...(COMMA_COMPOUND_SENTENCE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/content/docs/integrate/connected-apps/microsoft-365-connected-app.mdx(1 hunks)
🧰 Additional context used
🪛 LanguageTool
src/content/docs/integrate/connected-apps/microsoft-365-connected-app.mdx
[grammar] ~30-~30: In this case, the usual preposition with “side” is “on”, not “in”. Did you mean “on the left side”?
Context: ...o this from links on the main screen or in the left side menu. 3. Select **Add+ > App registrati...
(IN_ON_THE_RIGHT_HAND_SIDE)
[typographical] ~35-~35: The word “otherwise” is an adverb that can’t be used like a conjunction, and therefore needs to be separated from the sentence.
Context: ...omain> is your custom domain if you use one, otherwise this is your Kinde domain. 8. Select **...
(THUS_SENTENCE)
[uncategorized] ~37-~37: Use a comma before ‘or’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...client) ID** and paste it in a text file or somewhere you can easily access it agai...
(COMMA_COMPOUND_SENTENCE)
[uncategorized] ~59-~59: Use a comma before ‘or’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...lue** column and paste it in a text file or somewhere you can easily access it agai...
(COMMA_COMPOUND_SENTENCE)
🔇 Additional comments (3)
src/content/docs/integrate/connected-apps/microsoft-365-connected-app.mdx (3)
1-11: YAML Front Matter is Well Structured
The metadata including the page ID, title, sidebar order, and related articles is clearly defined and follows the expected YAML format.
13-24: Clear Introduction & Prerequisites Section
The introduction and "Before you begin" section succinctly state the purpose of the page and clearly list the prerequisites. This sets the right context for users looking to integrate Microsoft 365 with Kinde.
64-68: Final Connection Configuration Section is Clear
The final instructions for configuring the connection in Kinde are concise and direct, clearly listing the required items such as the Client ID, Secret, and callback URL.
New topic for adding Microsoft 365 connected app - specifically calendar for now
Updated reference in the master topic for Microsoft 365 connected app at step 2
Summary by CodeRabbit