split out require-config for reuse in tests#6
Open
CraigCav wants to merge 2 commits intokimjoar:masterfrom
Open
split out require-config for reuse in tests#6CraigCav wants to merge 2 commits intokimjoar:masterfrom
CraigCav wants to merge 2 commits intokimjoar:masterfrom
Conversation
|
Does that work with the paths defined in require-config? It seems to me that if |
|
@uuilee Check out that article Craig referenced :) |
|
@jugglinmike, thanks fot the reference. instead i had to do the following: In the former, it seemed that the |
|
This really should be merged, as it simplifies the setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than copy-pasting the requirejs.config paths and shims into the require.config for running tests, we can just load the applications requirejs configuration from
test-main.js.This PR was inspired by @jugglinmike's blog post on Effective Unit Testing with AMD.