Reuse and clean up JSC class ref bindings

Reviewed By: fkgozali Differential Revision: D7893634 fbshipit-source-id: de11cb93f9f7e7c935af2da4616671043438363b
kimihiro64 · May 15, 2018 · 6c58035 · 6c58035
1 parent 4a2c560
commit 6c58035
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/jsc/jni/FabricJSCBinding.cpp b/ReactAndroid/src/main/java/com/facebook/react/fabric/jsc/jni/FabricJSCBinding.cpp
@@ -33,10 +33,15 @@ typedef struct FabricJSCUIManager {
     : wrapperObjectClassRef(classRef)
     , useCustomJSC(customJSC) {
     fabricUiManager = make_global(module);
+    JSC_JSClassRetain(useCustomJSC, wrapperObjectClassRef);
   }
   global_ref<jobject> fabricUiManager;
   JSClassRef wrapperObjectClassRef;
   bool useCustomJSC;
+
+  ~FabricJSCUIManager() {
+    JSC_JSClassRelease(useCustomJSC, wrapperObjectClassRef);
+  }
 } FabricJSCUIManager;
 
 jobject makePlainGlobalRef(jobject object) {
@@ -283,6 +288,8 @@ void FabricJSCBinding::installFabric(jlong jsContextNativePointer,
   addFabricMethod(context, fabricModule, classRef, module, "appendChildToSet", appendChildToSet);
   addFabricMethod(context, fabricModule, classRef, module, "completeRoot", completeRoot);
 
+  JSC_JSClassRelease(useCustomJSC, classRef);
+
   JSObjectRef globalObject = JSC_JSContextGetGlobalObject(context);
   JSStringRef globalName = JSC_JSStringCreateWithUTF8CString(context, "nativeFabricUIManager");
   JSC_JSObjectSetProperty(context, globalObject, globalName, module, kJSPropertyAttributeNone, NULL);