Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to update CPU and Max vCPUs when topology is set #1072

Closed
alinefm opened this issue Nov 1, 2016 · 0 comments
Closed

Unable to update CPU and Max vCPUs when topology is set #1072

alinefm opened this issue Nov 1, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@alinefm
Copy link
Member

alinefm commented Nov 1, 2016

Seeing error "KCHCPUINF0005E: When CPU topology is defined, vCPUs must be a multiple of a product of cores and threads."

Though the guest is having the correct number of vCPUs matching the above equation.

sockets * cores * threads = vCPUs
10 * 6 * 4 = 240

Guest contains the following:
240


Re-production steps:

When the guest is offline.
Choose Actions -> Edit -> Change the 'max memory' value and click on 'Save'.

@alinefm alinefm added the bug label Nov 1, 2016
@alinefm alinefm added this to the Kimchi 2.3.1 milestone Nov 1, 2016
alinefm pushed a commit that referenced this issue Nov 24, 2016
Following the changes of bug fix #1072, this patch adds the
'sockets' values to be editable in the CPU topology. Since
sockets is now a component of the calculation of Max CPUs of
a VM, it makes sense to allow user control of it.

As with cores and threads, the defautl value of sockets is
returned by the cpu_info API.

Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
alinefm pushed a commit that referenced this issue Dec 1, 2016
This patch changes the vcpu verification when
editing a turned off VM, if the VM has a topology
set, to comply with the current libvirt schema: vcpus
must be a multiple of the 'threads' value.

Unit tests were adapted to reflect these changes.

Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
alinefm pushed a commit that referenced this issue Dec 1, 2016
Following the changes of bug fix #1072, this patch adds the
'sockets' values to be editable in the CPU topology. Since
sockets is now a component of the calculation of Max CPUs of
a VM, it makes sense to allow user control of it.

As with cores and threads, the defautl value of sockets is
returned by the cpu_info API.

Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
alinefm pushed a commit that referenced this issue May 29, 2018
This patch changes the vcpu verification when
editing a turned off VM, if the VM has a topology
set, to comply with the current libvirt schema: vcpus
must be a multiple of the 'threads' value.

Unit tests were adapted to reflect these changes.

Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
alinefm pushed a commit that referenced this issue May 29, 2018
Following the changes of bug fix #1072, this patch adds the
'sockets' values to be editable in the CPU topology. Since
sockets is now a component of the calculation of Max CPUs of
a VM, it makes sense to allow user control of it.

As with cores and threads, the defautl value of sockets is
returned by the cpu_info API.

Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
pgurenko pushed a commit to pgurenko/kimchi that referenced this issue Apr 22, 2019
This patch changes the vcpu verification when
editing a turned off VM, if the VM has a topology
set, to comply with the current libvirt schema: vcpus
must be a multiple of the 'threads' value.

Unit tests were adapted to reflect these changes.

Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
pgurenko pushed a commit to pgurenko/kimchi that referenced this issue Apr 22, 2019
Following the changes of bug fix kimchi-project#1072, this patch adds the
'sockets' values to be editable in the CPU topology. Since
sockets is now a component of the calculation of Max CPUs of
a VM, it makes sense to allow user control of it.

As with cores and threads, the defautl value of sockets is
returned by the cpu_info API.

Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants