Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validator to 0.19, to update idna to ^1 #57

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

Matthew-Pomes
Copy link
Contributor

Upgrades validator to 0.19, to eliminate any chance of using idna < 1. It's not clear whether the vulnerability applies to this library, but upgrading validator does not appear to effect this library either.

CVSS report:

Vulnerable Library - idna-0.5.0.crate

IDNA (Internationalizing Domain Names in Applications) and Punycode.

Library home page: https://static.crates.io/crates/idna/idna-0.5.0.crate

Path to dependency file: /Cargo.toml

Path to vulnerable library: /Cargo.toml

Dependency Hierarchy:

openid-0.15.0.crate
    validator-0.18.1.crate
        ❌ idna-0.5.0.crate (Vulnerable Library)

Found in HEAD commit: adf6187c75ee1de0439ea36e56aa5a17f1d0aeab

Found in base branch: main

Vulnerability Details

"idna" 0.5.0 and earlier accepts Punycode labels that do not produce any non-ASCII output, which means that either ASCII labels or the empty root label can be masked such that they appear unequal without IDNA processing or when processed with a different implementation and equal when processed with "idna" 0.5.0 or earlier.
Concretely, "example.org" and "xn--example-.org" become equal after processing by "idna" 0.5.0 or earlier. Also, "example.org.xn--" and "example.org." become equal after processing by "idna" 0.5.0 or earlier.
In applications using "idna" (but not in "idna" itself) this may be able to lead to privilege escalation when host name comparison is part of a privilege check and the behavior is combined with a client that resolves domains with such labels instead of treating them as errors that preclude DNS resolution / URL fetching and with the attacker managing to introduce a DNS entry (and TLS certificate) for an "xn--"-masked name that turns into the name of the target when processed by "idna" 0.5.0 or earlier.
Remedy
Upgrade to "idna" 1.0.3 or later, if depending on "idna" directly, or to "url" 2.5.4 or later, if depending on "idna" via "url". (This issue was fixed in "idna" 1.0.0, but versions earlier than 1.0.3 are not recommended for other reasons.)
When upgrading, please take a moment to read about "alternative Unicode back ends for "idna"" (https://docs.rs/crate/idna_adapter/latest).
If you are using Rust earlier than 1.81 in combination with SQLx 0.8.2 or earlier, please also read an "issue" (servo/rust-url#992) about combining them with "url" 2.5.4 and "idna" 1.0.3.
Additional information
This issue resulted from "idna" 0.5.0 and earlier implementing the UTS 46 specification literally on this point and the specification having this bug. The specification bug has been fixed in "revision 33 of UTS 46" (https://www.unicode.org/reports/tr46/tr46-33.html#Modifications).
Acknowledgements
Thanks to kageshiron for recognizing the security implications of this behavior.

Publish Date: 2024-12-09

URL: CVE-2024-12224

CVSS 3 Score Details (4.8)

Base Score Metrics:

Exploitability Metrics:
    Attack Vector: Network
    Attack Complexity: High
    Privileges Required: None
    User Interaction: None
    Scope: Unchanged
Impact Metrics:
    Confidentiality Impact: Low
    Integrity Impact: Low
    Availability Impact: None

For more information on CVSS3 Scores, click here.

Suggested Fix

Type: Upgrade version

Origin: GHSA-h97m-ww89-6jmq

Release Date: 2024-12-09

Fix Resolution: idna - 1.0.0

@kilork kilork merged commit 40ccc86 into kilork:master Dec 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants