Update validator to 0.19, to update idna to ^1 #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades validator to 0.19, to eliminate any chance of using idna < 1. It's not clear whether the vulnerability applies to this library, but upgrading validator does not appear to effect this library either.
CVSS report:
Vulnerable Library - idna-0.5.0.crate
IDNA (Internationalizing Domain Names in Applications) and Punycode.
Library home page: https://static.crates.io/crates/idna/idna-0.5.0.crate
Path to dependency file: /Cargo.toml
Path to vulnerable library: /Cargo.toml
Dependency Hierarchy:
Found in HEAD commit: adf6187c75ee1de0439ea36e56aa5a17f1d0aeab
Found in base branch: main
Vulnerability Details
"idna" 0.5.0 and earlier accepts Punycode labels that do not produce any non-ASCII output, which means that either ASCII labels or the empty root label can be masked such that they appear unequal without IDNA processing or when processed with a different implementation and equal when processed with "idna" 0.5.0 or earlier.
Concretely, "example.org" and "xn--example-.org" become equal after processing by "idna" 0.5.0 or earlier. Also, "example.org.xn--" and "example.org." become equal after processing by "idna" 0.5.0 or earlier.
In applications using "idna" (but not in "idna" itself) this may be able to lead to privilege escalation when host name comparison is part of a privilege check and the behavior is combined with a client that resolves domains with such labels instead of treating them as errors that preclude DNS resolution / URL fetching and with the attacker managing to introduce a DNS entry (and TLS certificate) for an "xn--"-masked name that turns into the name of the target when processed by "idna" 0.5.0 or earlier.
Remedy
Upgrade to "idna" 1.0.3 or later, if depending on "idna" directly, or to "url" 2.5.4 or later, if depending on "idna" via "url". (This issue was fixed in "idna" 1.0.0, but versions earlier than 1.0.3 are not recommended for other reasons.)
When upgrading, please take a moment to read about "alternative Unicode back ends for "idna"" (https://docs.rs/crate/idna_adapter/latest).
If you are using Rust earlier than 1.81 in combination with SQLx 0.8.2 or earlier, please also read an "issue" (servo/rust-url#992) about combining them with "url" 2.5.4 and "idna" 1.0.3.
Additional information
This issue resulted from "idna" 0.5.0 and earlier implementing the UTS 46 specification literally on this point and the specification having this bug. The specification bug has been fixed in "revision 33 of UTS 46" (https://www.unicode.org/reports/tr46/tr46-33.html#Modifications).
Acknowledgements
Thanks to kageshiron for recognizing the security implications of this behavior.
Publish Date: 2024-12-09
URL: CVE-2024-12224
CVSS 3 Score Details (4.8)
Base Score Metrics:
For more information on CVSS3 Scores, click here.
Suggested Fix
Type: Upgrade version
Origin: GHSA-h97m-ww89-6jmq
Release Date: 2024-12-09
Fix Resolution: idna - 1.0.0