Skip to content

Conversation

phadej
Copy link
Contributor

@phadej phadej commented Nov 20, 2015

No description provided.

@phadej phadej force-pushed the ghc-7.10.3 branch 3 times, most recently from a2ea66f to 7f0a34a Compare November 20, 2015 10:07
@phadej
Copy link
Contributor Author

phadej commented Nov 20, 2015

Last commit is optional, but I'd advice to have upper bounds.

@killy971
Copy link
Owner

For some reason I can't remember (might have been an article I read a while back), I had the impression that it was not such a good idea to add upper bounds, but maybe it was my misunderstanding.

Is it still a common practice to set upper bounds these days?

Also, how should the upper bound value be defined?
Is this a case by case decision?

@phadej
Copy link
Contributor Author

phadej commented Nov 24, 2015

One good answer on top of my head is haskell/cabal#2774 (comment) (related discussion before and after is worth reading if you have time).

So upper bounds here are forbidding next major release of each depedency, which might introduce breaking changes affecting hpc-hoveralls, like retry-0.7 did. This for example caused travis builds of purescript fail for no reason, that's how I found an issue with hpc-hoveralls.

killy971 added a commit that referenced this pull request Nov 24, 2015
Add upper bounds (fixes #54 and #56), add 7.8.4, 7.10.2 and 7.10.3 to travis matrix
@killy971 killy971 merged commit a80d115 into killy971:master Nov 24, 2015
@phadej phadej deleted the ghc-7.10.3 branch November 24, 2015 12:13
@killy971 killy971 added the bug label Nov 24, 2015
@killy971 killy971 added this to the v1.0.3 milestone Nov 24, 2015
This was referenced Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants