Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more UX/design debt #267

Merged
merged 7 commits into from
Aug 19, 2024
Merged

Fix more UX/design debt #267

merged 7 commits into from
Aug 19, 2024

Conversation

praseodym
Copy link
Contributor

@praseodym praseodym commented Aug 17, 2024

Fixes #101
Fixes part of #263

  • Show account setup alert only after setup page
    • Move "Je account is ingesteld" to overview page (@jorisleker also see my comment in Figma)
    • Only show alert after account setup page
    • Remove close button from "Alle stembureaus zijn twee keer ingevoerd"
      alert
  • Fix spacing on alerts
    • Fixes margin on "Alle stembureaus zijn twee keer ingevoerd"
      alert button
  • Fix styling of medium size button
    • Fixes padding of "Alle stembureaus zijn twee keer ingevoerd" alert
      button
  • Keep overview page empty while loading
  • Set fallback font for data entry input fields
  • Use number font on polling station number input

- Move "Je account is ingesteld" to overview page
- Only show alert after account setup page
- Remove close button from "Alle stembureaus zijn twee keer ingevoerd"
  alert
Fixes margin on "Alle stembureaus zijn twee keer ingevoerd"
alert button.
Fixes padding of "Alle stembureaus zijn twee keer ingevoerd" alert
button.
@praseodym praseodym self-assigned this Aug 17, 2024
@praseodym praseodym added the frontend Issues or pull requests that relate to the frontend label Aug 17, 2024
This was referenced Aug 17, 2024
@jorisleker
Copy link
Contributor

jorisleker commented Aug 19, 2024

@praseodym how to test this: 'Only show alert after account setup page'? When I open http://localhost:8080/, it automatically redirects me to /overview, without showing account creating / login screens.

Also: what curl command should I run to finalize my input and see the "Alle stembureaus zijn twee keer ingevoerd" alert?

@praseodym
Copy link
Contributor Author

@praseodym how to test this: 'Only show alert after account setup page'? When I open http://localhost:8080/, it automatically redirects me to /overview, without showing account creating / login screens.

In #259, the development screen was moved to /dev. The user login screen is still at /user/login.

Also: what curl command should I run to finalize my input and see the "Alle stembureaus zijn twee keer ingevoerd" alert?

curl -v -XPOST http://127.0.0.1:8080/api/polling_stations/1/data_entries/1/finalise after submitting a valid data entry form (all zeroes is valid).

@praseodym praseodym enabled auto-merge August 19, 2024 14:21
@praseodym praseodym added this pull request to the merge queue Aug 19, 2024
Merged via the queue into main with commit aff08d2 Aug 19, 2024
7 checks passed
@praseodym praseodym deleted the 101-fix-design-debt branch August 19, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues or pull requests that relate to the frontend ux debt
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

UX/design debt 2
3 participants