Added typescript definitions #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieraneglin
reviewed
May 11, 2020
index.d.ts
Outdated
Comment on lines
14
to
18
| public transform(value: string, tramsform: OtDiff): string; | ||
| public insert(value: string, tramsform: OtDiff): string; | ||
| public delete(value: string, tramsform: OtDiff): string; | ||
| public replace(value: string, tramsform: OtDiff): string; | ||
| public noop(value: string, tramsform: OtDiff): string; |
There was a problem hiding this comment.
can tramsform please be changed to transform?
kieraneglin
reviewed
May 11, 2020
index.d.ts
Outdated
| public noop(value: string, tramsform: OtDiff): string; | ||
| } | ||
|
|
||
| export interface IOtOpts { |
There was a problem hiding this comment.
nit: Can this be renamed to just OtOpts to avoid Hungarian notation?
|
Thank you for the PR! I've left some comments but this is a welcome addition. |
|
I'm sorry, I must have missed the notification :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.