Skip to content

Conversation

BLuedtke
Copy link
Collaborator

This closes #9
The path of the Semantics RCA build was swapped between Windows and Linux. I've swapped the respective paths in the config file to fix that. No other paths/names appear to be mixed up in the config.

@BLuedtke BLuedtke requested a review from a-sr March 10, 2022 11:14
@BLuedtke
Copy link
Collaborator Author

BLuedtke commented Mar 10, 2022

Judging by the automatic actions compilation, the naming is now correct.
One thing is confusing me however. I derived this branch from the master branch. A few weeks ago, my fixes for counterexamples missing inputs were merged into the master branch (#4).
If I setup a dev environment on this branch and compile Kieler myself, the counterexamples have inputs. When I download the compiled RCA, the counterexamples are missing inputs, i.e. behaving as if my fixes weren't there. It's a separate issue from this PR, but I'll have a look at the CI if I can find anything unusual regarding this.
Edit: Ah, it is indeed using the up-to-date source, but there's a bug/mistake in the implementation in VerificationPropertyCounterexample, I'll take care of that soon. -> Nvm, the default updatesite configured in build/pom.xml results in an out-of-date verification plugin. I think thats known already though, looking at the pull request 4.

@NiklasRentzCAU
Copy link
Member

Oh, my bad. Looks like I was not careful enough on the C&P for all the semantics artifacts. Thanks for fixing!

The other issue with the update site hosted on http://rtsys.informatik.uni-kiel.de/~kieler/updatesite/nightly/semantics/ is that the process of hosting the nightly update site has not yet fully migrated to the new repository, so the artifacts you find there are still from the (non-updated) old repository location. I'm currently on that. For this repository there are some special cases, so we'll have to look how it will work here.

@BLuedtke
Copy link
Collaborator Author

Good to know! Thank you for your work. I'm new to most CI-build setups, so naturally I didn't immediately understand what was going on. Now it's all clear 👍

Copy link
Member

@a-sr a-sr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @NiklasRentzCAU

@a-sr a-sr merged commit 16a2eab into master Mar 11, 2022
@a-sr a-sr deleted the bluedtke/9-github-actions-name-swap branch March 11, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github actions building Semantics product (RCA): Name of zip is swapped for Windows and Linux
3 participants