Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues-646] Duplicate timer created for Task SLA Due date with AsyncMode env setting #2352

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

elguardian
Copy link
Member

@elguardian
Copy link
Member Author

the async node access the metadata of the node being wrapped causing the node itself registering an SLA twice
once when it is scheduled and the other one when the node itself is triggered.

@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Contributor

@martinweiler martinweiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean fix, thanks @elguardian

@mareknovotny
Copy link
Member

jenkins do fdb

@martinweiler martinweiler added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Oct 27, 2023
@elguardian
Copy link
Member Author

@gmunozfe need this to be reviewed.

Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great fix @elguardian !

@mareknovotny
Copy link
Member

@elguardian elguardian merged commit 063e3e4 into kiegroup:main Nov 2, 2023
9 of 10 checks passed
elguardian added a commit that referenced this pull request Nov 2, 2023
…LA Due date with AsyncMode env setting (#2352)"

This reverts commit 063e3e4.
github-actions bot pushed a commit that referenced this pull request Nov 2, 2023
github-actions bot pushed a commit that referenced this pull request Nov 2, 2023
@elguardian elguardian deleted the incubator-kie-issues-646 branch November 2, 2023 14:19
@elguardian
Copy link
Member Author

@martinweiler this #2355 should be in when creating the patch as well.

fjtirado pushed a commit to fjtirado/jbpm that referenced this pull request Nov 7, 2023
mareknovotny added a commit that referenced this pull request Jan 22, 2024
…SLA Due date with AsyncMode env setting (#2354)

* [incubator-kie-issues-646] Duplicate timer created for Task SLA Due date with AsyncMode env setting (#2352)

* fixed recursion

Co-authored-by: Gonzalo Muñoz <gmunozfe@redhat.com>

---------

Co-authored-by: Enrique <enrique.gonzalez.martinez1@ibm.com>
Co-authored-by: Marek Novotný <hotmana76@gmail.com>
Co-authored-by: Gonzalo Muñoz <gmunozfe@redhat.com>
fjtirado pushed a commit that referenced this pull request Feb 6, 2024
…Task SLA Due date with AsyncMode env setting (#2353)

* [incubator-kie-issues-646] Duplicate timer created for Task SLA Due date with AsyncMode env setting (#2352)

* Update jbpm-flow/src/main/java/org/jbpm/workflow/core/node/AsyncEventNode.java

Co-authored-by: Gonzalo Muñoz <gmunozfe@redhat.com>

---------

Co-authored-by: Enrique <enrique.gonzalez.martinez1@ibm.com>
Co-authored-by: Marek Novotný <hotmana76@gmail.com>
Co-authored-by: Gonzalo Muñoz <gmunozfe@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants