-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JBPM-6892 - Remove spacing between table results and controls #988
Conversation
@cristianonicolai I'm getting the following compilation error when trying to build jbpm-wb:
I have the dependent appformer commit in place, so not sure where is this error coming from. |
fecbf36
to
b92da7c
Compare
@bsremac give it another go, I rebased this PR |
@bsremac thanks, I had to increase the spacing to fix the horizontal slider issue. Strangely enough, this seems to only happen on Firefox. |
@cristianonicolai I don't see the horizontal slider now at all, when I navigate to perspectives which don't have an empty list: However, if there's more than one page, the slider appears on the next page: Again, I see this inconsistency only in Firefox. As an aside, what is the expected behavior with these sliders anyway. When is it expected for them to appear? |
@bsremac ok, let me take another look, these sliders should not show up at any time, at least I can't find a reason for that, apart from the overall height in the table that somehow affects it. |
@cristianonicolai After the latest changes in appformer PR, the horizontal slider deosn't appear anymore in Firefox - that's fine. |
@bsremac yeah, that happens because the table height is recalculated. I tried getting away from that but it simply doesn't work for the GWT table implementation, it needs to know/calculate the table height. Ideally, the selector and paging should just be there after the table uses its space. |
@cristianonicolai I get it. Well, I guess we will have to live with certain limitations :) |
…PM-6659, JBPM-6660 - Runtime views update, new Manage section (#994) * JBPM-6802:Add breadcrumbs to list and details views * Update Breadcrumb i18n keys * Use definition name instead of deployment id for breadcrumb * JBPM-6803: Migrate server template selector to breadcrumb area. * Migrate runtime views to new perspective layout * Move detail screens to full screen * Review toolbar primary action buttons * Review master detail API (#12) Remove table style for selected row Remove place status handling for opening details screen * Add new filters dock panel (#10) * JBPM-6826:Include Manage selector ( Inventory Switcher ) (#11) * Update attribute selector label to Filter By (#15) * Remove user task list from manage section (#14) * Add new saved filters dock panel (#9) * JBPM-6877 - Fix screen id for navigating to task and process instance details screens (#16) * [AF-913]: Added Category to resource type and integrated with UX/UI (#966) (#18) [AF-913]: Added Category to resource type * JBPM-6846: Move process model to detail tab (#13) * JBPM-6887 - Rename Task Lists to Task Inbox (#986) (#19) * JBPM-6892 - Remove spacing between table results and controls (#988) (#22) * JBPM-6841: Review details page layout. Details alignment, input fields size, primary button review and task context tab removed (#20) * JBPM-6867 - Restyle manage view table (#17) * JBPM-6885 - Split Task & Process Dashboard tabs into separated screens (#987) (#23) * JBPM-6867 - Layout updates to manage result list (#24) - Fix scrolling - Remove table rows stripes - Add grey background to table header * JBPM-6879: Prepend "Manage" to all runtime management list views breadcrumb (#25) * error detail breadcrumb updated with the error detail title (#21) * Upgrade supported WildFly version to 11. (#983) (#26) * Upgrade supported WildFly version to 11. This reverts commit 1d8f778. * Clean up auth properties files comments * fixed server logging in GWT SDM * JBPM-6174: Add error count column to the task admin list (#965) (#27) * JBPM-6825 - Move saved and quick filters to docks (#28) * JBPM-6881 : Rename Task Administration menu to Tasks (#30) * JBPM-6879: Prepend "Manage" to all runtime management list views breadcrumb. Process definition breadcrumb from new instance (#31) * JBPM-6841: Review details page layout. Spacing between tab header and content (#32) * JBPM-6886 : Update Dashboards layout (#29) * JBPM-7002 - Group action buttons in list table to kebab (#33) * Enhance filters tests (#34) * JBPM-6894 - User should be able to define case, process, activity level SLA (#990) (#36) * JBPM-6793 - Remove onclick and onmouseover in process diagram svg content (#37) * Increase space between tab and content in task admin and assignment tabs (#39) * Test addition: Breadcrumbs and ManageSelector (#38)
Depends on kiegroup/appformer#202