Use containsOnly insead of containsExactly in ProcessInstanceDiagramPresenterTest.java #1433
Conversation
make assertion order-agnostic
|
Can one of the admins verify this PR? Comment with 'ok to test' to start the build. |
3 similar comments
|
Can one of the admins verify this PR? Comment with 'ok to test' to start the build. |
|
Can one of the admins verify this PR? Comment with 'ok to test' to start the build. |
|
Can one of the admins verify this PR? Comment with 'ok to test' to start the build. |
|
ok to test |
|
Can one of the admins verify this patch? |
11 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
The test in
org.jbpm.workbench.pr.client.editors.instance.diagram.ProcessInstanceDiagramPresenterTest#testOnProcessInstanceSelectionEventcan fail due to a different iteration order ofMap. The failure is presented as follows:java.lang.AssertionError:Actual and expected have the same elements but not in the same order, at index 0 actual element was:<MapEntry[key="_2", value=1L]>whereas expected element was:<_1=1>The fix is to use
containsOnlyinstead ofcontainsExactlyso that the iteration order ofMapdoes not make the assertion fail. In this way, the test will be more robust, and the failure above will be removed.