OAuth2 client_credentials: fix validation gaps and harden test coverage#413
Merged
Merged
Conversation
github-project-automation
Bot
moved this to 📋 Backlog
in Kiali Sprint 26-08 | Kiali v2.28
jmazzitelli
moved this from 📋 Backlog
to 🏗 In progress
in Kiali Sprint 26-08 | Kiali v2.28
jmazzitelli
force-pushed
the
9787-oauth-client-followup
branch
from
357827c to
bd51568
Compare
Addresses follow-up issues identified during review of the OAuth2 client_credentials feature: missing client_secret validation, validation firing for disabled services, and gaps in test coverage across services. fixes: kiali/kiali#9787
jmazzitelli
force-pushed
the
9787-oauth-client-followup
branch
from
bd51568 to
6422e33
Compare
jmazzitelli
moved this from 🏗 In progress
to 👀 In review
in Kiali Sprint 26-08 | Kiali v2.28
jshaughn
approved these changes
Jun 2, 2026
| {{- if .Values.external_services }} | ||
| {{- /* Prometheus - only if enabled (defaults to true when not set) */ -}} | ||
| {{- if and .Values.external_services.prometheus (not (eq (toString .Values.external_services.prometheus.enabled) "false")) .Values.external_services.prometheus.auth }} | ||
| {{- if and .Values.external_services.prometheus (not (eq (toString .Values.external_services.prometheus.enabled | default "true") "false")) .Values.external_services.prometheus.auth }} |
Contributor
There was a problem hiding this comment.
Not sure this default "true" does anything but I don't think it's a big deal.
Contributor
Author
There was a problem hiding this comment.
that was actually added because AI thought this would be confusing without it (this follows the pattern everywhere else)
github-project-automation
Bot
moved this from 👀 In review
to ✅ Done
in Kiali Sprint 26-08 | Kiali v2.28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses follow-up issues identified during review of the OAuth2 client_credentials feature: missing client_secret validation, validation firing for disabled services, and gaps in test coverage across services.
fixes: kiali/kiali#9787