Skip to content

Conversation

towanda
Copy link

@towanda towanda commented Nov 29, 2017

No description provided.


it 'runs a request to refresh the token' do
expect(Feedlr::Request)
.to receive(:new).with(arguments).and_return(request)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Place the . on the previous line, together with the method call receiver.

end
let(:request) { Feedlr::Request.new(arguments) }

it 'runs a request to refresh the token' do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

{
client: client,
method: :post,
path: '/auth/token',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

refresh_token: refresh_oauth_token,
client_id: 'feedlydev',
client_secret: 'feedlydev',
grant_type: 'refresh_token',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

{
refresh_token: refresh_oauth_token,
client_id: 'feedlydev',
client_secret: 'feedlydev',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.


describe '#oauth_refresh_token' do
it 'should default to Feedlr.oauth_refresh_token if not set' do
Feedlr.configure { |c| c.oauth_refresh_token = 'test' }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

end

describe '#oauth_refresh_token' do
it 'should default to Feedlr.oauth_refresh_token if not set' do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

end
end

describe '#oauth_refresh_token' do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

client: self,
method: :post,
path: '/auth/token',
params: params).perform
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

Request.new(
client: self,
method: :post,
path: '/auth/token',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage increased (+0.2%) to 100.0% when pulling a54f41a on towanda:add-refresh-token-option into a47462a on khelll:master.

@towanda towanda force-pushed the add-refresh-token-option branch from a54f41a to 30406a3 Compare November 29, 2017 17:06
@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage increased (+0.2%) to 100.0% when pulling 30406a3 on towanda:add-refresh-token-option into a47462a on khelll:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 100.0% when pulling 30406a3 on towanda:add-refresh-token-option into a47462a on khelll:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants