Move MVC factory registration into MVC-specific extension method

khellang · Mar 15, 2021 · 9c2443b · 9c2443b
1 parent 92268f5
commit 9c2443b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/ProblemDetails/Mvc/MvcBuilderExtensions.cs b/src/ProblemDetails/Mvc/MvcBuilderExtensions.cs
@@ -3,6 +3,7 @@
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.DependencyInjection.Extensions;
 using Microsoft.Extensions.Options;
+using MvcProblemDetailsFactory = Microsoft.AspNetCore.Mvc.Infrastructure.ProblemDetailsFactory;
 
 namespace Hellang.Middleware.ProblemDetails.Mvc
 {
@@ -18,6 +19,9 @@ public static class MvcBuilderExtensions
         /// <returns>The <see cref="IMvcBuilder"/>.</returns>
         public static IMvcBuilder AddProblemDetailsConventions(this IMvcBuilder builder)
         {
+            // Forward the MVC problem details factory registration to the factory used by the middleware.
+            builder.Services.TryAddSingleton<MvcProblemDetailsFactory>(p => p.GetRequiredService<ProblemDetailsFactory>());
+
             builder.Services.TryAddEnumerable(
                 ServiceDescriptor.Transient<IConfigureOptions<ApiBehaviorOptions>, ProblemDetailsApiBehaviorOptionsSetup>());
 

diff --git a/src/ProblemDetails/ProblemDetailsExtensions.cs b/src/ProblemDetails/ProblemDetailsExtensions.cs
@@ -3,7 +3,6 @@
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.DependencyInjection.Extensions;
 using Microsoft.Extensions.Options;
-using MvcProblemDetailsFactory = Microsoft.AspNetCore.Mvc.Infrastructure.ProblemDetailsFactory;
 
 namespace Hellang.Middleware.ProblemDetails
 {
@@ -33,7 +32,6 @@ public static IServiceCollection AddProblemDetails(this IServiceCollection servi
             }
 
             services.TryAddSingleton<ProblemDetailsFactory>();
-            services.TryAddSingleton<MvcProblemDetailsFactory>(p => p.GetRequiredService<ProblemDetailsFactory>());
             services.TryAddSingleton<ProblemDetailsMarkerService, ProblemDetailsMarkerService>();
             services.TryAddEnumerable(ServiceDescriptor.Transient<IConfigureOptions<ProblemDetailsOptions>, ProblemDetailsOptionsSetup>());