updated approach for open isosurface creation #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I think i was tired when i tried the "second largest CC" mask last week. An easier way is to get the largest CC of invalid vertices (i.e. those outside of the coords mask), and discard those. This keeps the surface intact in holes (which are islands of invalid vertices). I think this is pretty simple and elegant, doesn't introduce any new parameters or dependencies, and adds negligible processing time. Let me know how it works in your test cases @akhanf |
Member
|
Sounds good will give it a whirl. Logic seems sound to me. |
akhanf
changed the title
Member
|
merging this in -- fyi I changed the title to describe the change |
Dhananjhay
pushed a commit
that referenced
this pull request
Aug 5, 2025
* no coords masking; instead remove outersurf by removing the largest connected component of outside (invalid) vertices * improved robustness for holes in mesh note: reducing the voxel size for laminar_coords_res usually fixes any residual holes
Dhananjhay
pushed a commit
that referenced
this pull request
Aug 18, 2025
* no coords masking; instead remove outersurf by removing the largest connected component of outside (invalid) vertices * improved robustness for holes in mesh note: reducing the voxel size for laminar_coords_res usually fixes any residual holes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In principle this is a pretty simple fix, we just take out the extra dilated nan mask and then find a way to remove the unwanted components of the surface. This would be better than postprocessing to patch holes since it allows for a smooth&curvy surface.
Here i tried keeping the second largest connected component but it must be connected somewhere because that effectively removes the whole thing
Would also need to remove from dg:
some other masking of the bg might work, will look into it later