Skip to content

[WIP] Update group target #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] Update group target #64

wants to merge 1 commit into from

Conversation

kaitj
Copy link

@kaitj kaitj commented Jun 23, 2023

This (WIP) PR updates the workflow to make use of the concat_subj_csv rule in tables.smk, updating the expected input and output files, as well as update the target group rule by adding a get_group_tables() function to create a concatenated, metric-specific table. Additionally, a python script is run at the target rule to combine the concatenated tables into a single, combined table.

The one issue currently is if the group target rule is run without first running the workflow again with --touch, it will rerun rules within the workflow again trying to update the input files. This only occurs if the workflow is submitted to the slurm scheduler - was not needed in interactive testing of the workflow.

@kaitj kaitj added the enhancement New feature or request label Jun 23, 2023
@kaitj kaitj self-assigned this Jun 23, 2023
@kaitj kaitj force-pushed the maint/concat_csv branch from 16696d8 to 978cd73 Compare June 23, 2023 15:54
@kaitj kaitj changed the title [WIP] Update group target Update group target Jun 23, 2023
@kaitj kaitj changed the title Update group target [WIP] Update group target Jun 23, 2023
@kaitj kaitj force-pushed the maint/concat_csv branch from 978cd73 to ad8d2ae Compare June 23, 2023 23:32
- add additional group target rule in Snakefile
  - rule still outputs all of the expected files from subject, changed
    the expected output table
  - target rule comines all individual csvs to a single file
- updated concat_subj_csv rule in tables.smk
@kaitj kaitj force-pushed the maint/concat_csv branch from ad8d2ae to 322e657 Compare June 24, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant