Added RSpec as a runtime and development dependency for the gem #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you like PR #41 I recommend you merge that first to run RSpec for this PR. |
|
Thank you, @itay-grudev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If RSpec is not a runtime dependency, if the gem is included before RSpec in your Gemfile it may results in issues, because RSpec hasn't been loaded yet.
For example, in my project this causes:
The bypass is simple, add it after
gem 'rspec', but the actual cause is simply that the gem needsRSpecas a runtime dependency as well as a development dependency - hence the change.P.S. I hope I wasn't being presumptions when filling your
CHANGELOGand versions. I just wanted to save you the hassle of doing that.