Label K8s resources correctly for easier cleanup #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use one simplified `kubectl delete` command with long CLI switches for descriptiveness. Also remove the unused gRPC client. Signed-off-by: David Xia <david@davidxia.com>
Contributor
|
Hi @davidxia thanks for your contribution. We have gotten conflicting feedback from other people that it is confusing to use labels that are not required (even if they are for helpful things like cleanup, as you have). This is because some users then think the label is required to use grpc, for example. So we are actually trying to avoid using non-essential labels, although I am sure we still have it left over in a few places, such as you found. Could you change this PR to remove the labels in this guide instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use one simplified
kubectl deletecommand with long CLI switches for descriptiveness. Also remove the unused gRPC client.Change Type