Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#620] feat: Effect Info Card and Summary #874

Merged
merged 20 commits into from
Dec 18, 2024
Merged

[#620] feat: Effect Info Card and Summary #874

merged 20 commits into from
Dec 18, 2024

Conversation

kgar
Copy link
Owner

@kgar kgar commented Dec 18, 2024 •
edited
Loading

#620

  • Fixed: Activities icons were inconsistently sized between SVG and img.
  • New: Effect Card on hover - actors and items
  • New: Effect Summary - actors
  • New: Toggle Effect Card On/Off in settings (default: on)
  • Fixed: When item names are italicized, the last letter sometimes clips
  • Fixed: Compendium sheets were not showing the Import for App V2 content (Group, Item, Container)
  • Fixed: Compendium sheets were not allowing dragging active effects. This feature is needed for the common use case of dragging template item effects onto items to enchant them with +1 / +2 / +3, etc. a la the DMG module

kgar added 20 commits December 16, 2024 16:33
@kgar
Made unlist utility class generally available.
579319e 
Repathed item-info-card to info-card.

Implemented Effect Info Card.

Added support for attribute splatting on item table row.

Added uuid to actor effects processing.

Wired up effect cards for all actors and items.
@kgar
Removed setting for including item cards for NPCs/Vehicles. It's now …
09a9e99 
…just On/Off across the board.

Updated code to enforce item card configuration.

Added client setting for using effect cards, default on.
@kgar
- [x] Refactor: Include info card outside of the main sheet component…
d6a803e 
… as an additional component, ambiently included by the sheet class.
@kgar
Implemented Import button for App V2 sheets.
b5b5b77
@kgar
Persisting my todo notes for now 🎶
597704f
@kgar
Added Import button to the header proper.
c3f364e
@kgar
Cleaned up and consolidated import button setup as much as App V2 all…
1bd3a99 
…ows.
@kgar
Ensured active effects and activities on item sheets are draggable in…
515080a 
… locked compendia. This supports the DMG feature of enchanting items from templates.

Refined inline activities list styles.
@kgar
Making plans
8a3aa35
@kgar
Began implementing effect summary.
268b604
@kgar
Fixed effect info card bug. Added type satisfying assertions to each …
4865002 
…of the card assignments.
@kgar
Finished effect summary.
bd629c1 
Added overflow word breaking to effect info card so that long keys break to new lines.
@kgar
Finished styling up effect table row.
f7b04be
@kgar
Fixed issue with italic item names clipping. Added flex-1.
4fcf598 
Implemented effect toggle summary on Character Effects tab.

Fixed issue with container primary cell not being marked as primary and unintentionally centering text.
@kgar
- [x] Fixed: When collapsing the item summary, it changes to `[object…
bc87549 
… Object]`. It's the effect causing it in ItemTableRow.
@kgar
Removed to-do file now that to-done.
3167037
@kgar
Extracted common active effect summarization code to share.
05db40f
@kgar
Fixed bug in effect summary.
d4ae64c 
Extended effect summary/card to NPCs and Vehicles.
@kgar
Removed active effect content from item table row component.
4d9e1bc
@kgar
Fixed check error.
bec4cba
@kgar kgar merged commit 4ac482f into main Dec 18, 2024
1 check passed
@kgar kgar deleted the effect-info-cards branch December 18, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kgar