WIP: container sheet overhaul, with file structure changes #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…paration for the new variable setup.
Rearranged how variables are imported into the main tidy5e scss file.
Added dedicated hightouch container sheet context. Generalized the edit mode toggles so they work with any document context. Began adding styles to the new hightouch setup.
…ables, text, and floating context menu to the top.
Began laying out the item/container sheet.
…area (sidebar side included), instead of just above the main content. Added image for sidebar. Established sidebar background. Set minimized width for all App V2 apps.
Added component styles for pills. Began filling out the container sidebar with content.
Added empty string fallback to rarity text.
Added container document name that is editable when the sheet is unlocked. Added support for container sheet lock.
Added toggles component styles.
Moved the burden of adding a sheet lock to the calling component, via _createAdditionalComponents protected member. Styled the app window and added the default texture. Added spacing for sheet lock. Added configurable source component. Styled the document name input when unlocked. Factored optional border width into Tidy switch. Made more of the switch customizable. Styled the hightouch style sheet lock using Tidy switch. Removed the old tab strip, as a new one is in order for the new sheets.
Added temp content for hightouch tabs to coexist with classic container sheet tabs. Added text color util classes. Corrected default font-family. Added currency icon classes. Added item header summary section and styled up. Applied minor style fixes here and there. Made source text properly truncatable. Stubbed ItemDescriptionsTab. Stubbed ContainerDetailsTab.
…ize is increased.
Moved item parts to the item folder. I'll just have container borrow from the item namespace since they are so close in nature.
Moved background to items scss. Reworked item sheet background to match the Figma design more closely.
Added fonts scss file and moved all font face declarations to there. Added all the new roboto condensed weights / italic declarations. Moved classic tab styles to the classic stylesheets as a component style import. Added tab strip styles for item sheet tabs.
Added scrolling for window container. Added golden fade separator and removed tab strip `::before` content. Added separators stylesheet. Added stub components for capacity bar, container contents sections, and inline container view. Added webp version of banner. Extracted item table row v2 scoped styles the classic tidy table styles. Made the classing more distinct. Scaffolded the basic components of the container contents tab.
…tem table layouts. Standardized some more variable names. Added specificity to app.scss that pertains to app v2, to help better override styles. Added buttons and tidy tables component SCSS files and imported into the hightouch component styles. Began laying out tidy tables for container contents.
…mns. Updated the tidy table component to officially accept gridTemplateColumns and apply it to its own styles, to cut down on display contents divs with variables attached to them.
Added vertical filigree guideline component. Updated tidy table styles to account for sub-table overrides. Continued to refine table styles.
…perties section not implemented yet.
Made minor tweaks and adjustments. Removed mention of quantity on the container sheet because containers cannot be any other quantity than 1.
… editor sections.
Added attunement toggle to container sheet that shows when attunement is applicable.
…nto the contents tab properly.
Implemented currency convert and item creation buttons on container sheet. Configured thresholds for showing higher severities on capacity bar. Formally added styles for the attention button.
…of the available vertical space in the item description tab.
Added background color for item summaries in hightouch tidy tables. Added layout component style.
…ntainer-sheet-overhaul
…ong for tabs and item contents. Added remainder of toolbar elements without yet any implementation. 🎉 Perfectly centered custom radio buttons. Added styles for button option menu content. Added outline to button reset to clear the orange Foundry outline on focus. Fixed type errors on PillSwitch by using callbacks rather than the on: syntax. Implemented button option panel anchoring so that a panel on the far right of the sheet will show without issues. Added loc keys for new content.
Made more minor adjustments to container sheet styles. Changed container contents so that the footer is pushed to the bottom of the content area.
…ntainer-sheet-overhaul
…dy5e-sheet-2 into container-sheet-overhaul
…ntainer-sheet-overhaul
…ntainer-sheet-overhaul
Made activation-based activity filters null-safe, since Facilities do not have this property at all. Updated Activity Favorites table so it uses the grid template columns prop instead of a wrapper element with CSS variable.
Disabled visual overhaul content as it is going to dev.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.