[#40] Localization Revisions, Preparation, and Maintenance #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delineated Sheet Edit from Sheet Lock.
Revamped the context menu actions and other localization variables to say less. Compacted some composite variables that were structurally imposing unintentional language conventions on potential translations. Applied some light revisions to wording and capitalization. Made search-related localization say less.
Refactored freeze key to be fix key in the ItemInfoCard component. Reversed wording on inspiration tracker animation so that it is positive-oriented rather than a disabling feature. Standardized NPC and vehicle setting headers. Removed unused variables.
Finished initial pass reviewing and revising grammar and word choice. Renamed numerous settings. Reversed the logic on numerous settings so that they are positive-oriented to simplify their use and stick to the convention. Separated standard encumbrance into character and vehicle encumbrance settings to make configuration simpler and less about other modules and more about whether to show these sheet parts. This conceptually removes them from being specifically for the purpose of rule variance or alternative encumbrance modules.
Updated module.json with lang files.
Swapped out top-level localization namespace for the temp alpha testing one.
Synchronized all lang files with en.json. Reversed settings: - characterJournalTabDisabled -> useJournalTabForCharacter - journalTabNPCDisabled -> useJournalTabForNpc Renamed settings: - enableClassicControlsForCharacter -> useClassicControlsForCharacter - enableClassicControlsForNpc -> useClassicControlsForNpc - enableClassicControlsForVehicle -> useClassicControlsForVehicle Added context settings where appropriate. Sorted type declaration props accordingly.
Renamed more settings and localization keys are reviewing settings / localization again. Reversed a few more settings.
… remainder of non-uppercase NPCs.
Removed extra brace on some text.
Corrected references to existing localization keys.
Adjusted h3 size in settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#40
Major Localization / Settings Overhaul
Warning
Breaking changes: Numerous config settings have changed meaning and name. Any setting whose name has changed will reset to its default value. If your sheet setup has changed when upgrading, visit Sheet Settings and/or Theme Settings to re-apply your desired settings.
en.jsonlang file.Coming Soon: Weblate for Tidy 5e Sheets
As part of this upgrade, @kgar is setting up the Tidy 5e Sheets rewrite in Foundry Hub Weblate so that localization is easier and doesn't require translators to fuss with Github or pull requests. Weblate also provides a number of compelling quality-of-life features.