Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @dancazarin ,
I am migrating a code from matlab to cpp and I am facing issues very similar to #148 and #191.
Furthermore, I totally agree with #168 regarding the documentation; in particular, of IIR filters.
After some trial and error I'd like to document my findings regarding the input parameters of the iir_filter functions.
Since I can choose where to do that, I think the best place possible is the original repo itself. Thus I have forked and opened this PR.
This is just a draft of where the improvements in the docs should go, as far as I understand. If the commits are correct, the same approach could be applied systematically to the rest of IIR filters.
In fact, I think it would be even better to make the functioon headers and parameters analogous to the FIR filters, to make it more intuitive. If in FIR input frequencies are normalized with respect to f_nyquist_Hz=f_sampling_Hz/2, shouldn't the same criterion be applied for IIR functions?
If it is OK, we can discuss about it in this PR. I hope it was OK to open it directly with a couple of commits without opening an issue first.