Skip to content

Search for android build plugin version in full classpath #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2020
Merged

Search for android build plugin version in full classpath #173

merged 2 commits into from
Aug 12, 2020

Conversation

mkopec87
Copy link
Contributor

Closes #172

@kezong
Copy link
Owner

kezong commented Aug 12, 2020

Thanks for the PR.
I suggest that the original logic can be retained. When the version of root cannot be obtained, it can be searched in other modules. I will merge it first and modify it later.

@kezong kezong merged commit 7e12a02 into kezong:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin cannot be used if "com.android.tools.build:gradle" is not explicitly defined in root gradle file
2 participants
@mkopec87 @kezong