fix(core): mutations are non-transactional, leaving orphaned/partial data - #9911
Open
imhayatunnabi wants to merge 1 commit into
Open
fix(core): mutations are non-transactional, leaving orphaned/partial data#9911imhayatunnabi wants to merge 1 commit into
imhayatunnabi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem I have faced in bulk + large data operations:
create,update,deleteand their*Manyvariants inpackages/core/src/lib/core/mutations/index.tswrite itemsnon-transactionally — there is no
$transactionanywhere in the mutation path.Because nested
createinputs are persisted before the parent row is written,if the parent write then fails (avalidate/beforeOperationhook, a DB constraint, etc.), the already-created related rows are left orphaned in the database with no rollback — the item ends up partially written.For
createMany/updateMany/deleteManyeach item is committed independently, so a batch that fails partway leaves earlier items committed and later ones not.