Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field labels for structured JSON array fields #8493

Merged
merged 4 commits into from
Apr 19, 2023
Merged

Conversation

borisno2
Copy link
Member

@borisno2 borisno2 commented Apr 18, 2023

Currently, a nested array field does not have a heading label so looks like this:
Screenshot 2023-04-18 at 1 29 42 pm
This makes it hard to distinguish between nested array fields until an item is added.

The current label is really just an itemLabel field, so only is visible after an item is added:

Screenshot 2023-04-18 at 1 33 14 pm

This PR adds changes the current label to itemLabel and label is now the field label and displays that above the array
Screenshot 2023-04-18 at 1 35 11 pm

@changeset-bot

This comment was marked as resolved.

@borisno2 borisno2 requested a review from dcousens April 18, 2023 03:39
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 50680aa:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens dcousens changed the title Add ability to set field label on a Structured JSON array field Add field labels for structured JSON array fields Apr 19, 2023
@dcousens dcousens merged commit 2c404c3 into main Apr 19, 2023
@dcousens dcousens deleted the structure-json-ui branch April 19, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants