Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only setup express server when necessary in tests #7871

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

emmatown
Copy link
Member

This is because setting up the express server is somewhat expensive but most tests don't need it. The documentation updates for this will be in a separate PR.

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2022

🦋 Changeset detected

Latest commit: 77d7317

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@keystone-6/core Major
@keystone-6/example-assets-local Patch
@keystone-6/example-assets-s3 Patch
@keystone-6/example-auth Patch
@keystone-6/example-app-basic Patch
@keystone-6/example-blog Patch
@keystone-6/example-custom-admin-ui-logo Patch
@keystone-6/example-custom-admin-ui-navigation Patch
@keystone-6/example-custom-admin-ui-pages Patch
@keystone-6/example-custom-field-view Patch
@keystone-6/example-custom-field Patch
@keystone-6/example-with-custom-session-validation Patch
@keystone-6/example-default-values Patch
@keystone-6/example-document-field Patch
@keystone-6/example-ecommerce Patch
@keystone-6/example-embedded-nextjs Patch
@keystone-6/example-extend-graphql-schema-graphql-ts Patch
@keystone-6/example-extend-graphql-schema-nexus Patch
@keystone-6/example-extend-graphql-schema Patch
@keystone-6/example-extend-graphql-subscriptions Patch
@keystone-6/example-graphql-api-endpoint Patch
@keystone-6/example-json-field Patch
@keystone-6/example-rest-api Patch
@keystone-6/example-roles Patch
@keystone-6/example-task-manager Patch
@keystone-6/example-testing Patch
@keystone-6/example-virtual-field Patch
@keystone-6/example-with-auth Patch
@keystone-6/auth Major
@keystone-6/cloudinary Major
@keystone-6/fields-document Major
@keystone-6/session-store-redis Major
@keystone-6/benchmarks-legacy Patch
@keystone-6/test-projects-basic Patch
@keystone-6/test-projects-crud-notifications Patch
@keystone-6/test-projects-live-reloading Patch
@keystone-6/sandbox Patch
@keystone-6/generate-artifacts-for-projects Patch
@keystone-6/website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Aug 31, 2022 at 4:44AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 31, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 77d7317:

Sandbox Source
@keystone-6/sandbox Configuration

@vercel vercel bot temporarily deployed to Preview August 31, 2022 04:35 Inactive
@emmatown emmatown marked this pull request as ready for review August 31, 2022 04:40
@emmatown emmatown force-pushed the only-setup-express-server-when-necessary branch from bb5889e to 77d7317 Compare August 31, 2022 04:42
@vercel vercel bot temporarily deployed to Preview August 31, 2022 04:44 Inactive
@dcousens dcousens self-assigned this Aug 31, 2022
@emmatown emmatown requested a review from a team August 31, 2022 05:41
@dcousens dcousens merged commit 7508657 into main Aug 31, 2022
@dcousens dcousens deleted the only-setup-express-server-when-necessary branch August 31, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants