Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide clear for segmented-control #7639

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

u-ishii
Copy link
Contributor

@u-ishii u-ishii commented Jun 16, 2022

Fix #7413

Hide the clear button if is-required is true for segmented-control.

I confirmed that this fix works as expected in sandbox, but if you find a problem, please comment.

@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2022

🦋 Changeset detected

Latest commit: d53ea97

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-6/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Jun 16, 2022 at 6:52PM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d53ea97:

Sandbox Source
@keystone-6/sandbox Configuration

@vercel vercel bot temporarily deployed to Preview June 16, 2022 18:52 Inactive
@dcousens
Copy link
Member

Thanks for this @u-ishii!

@dcousens dcousens merged commit a48fe5e into keystonejs:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select shouldn't show Clear button if validation.isRequired is true
3 participants