Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make seed data work better with KS6 #7094

Merged
merged 1 commit into from
Dec 21, 2021
Merged

make seed data work better with KS6 #7094

merged 1 commit into from
Dec 21, 2021

Conversation

Noviny
Copy link
Contributor

@Noviny Noviny commented Dec 20, 2021

During the KS6 upgrade, examples were kept working, but the data seeding got left behind a bit.

Fixed it so we are no longer doing try/catches

Also, while the add functions were returning data, we were not doing anything with it, so I stopped returning things.

@Noviny Noviny requested a review from bladey December 20, 2021 01:01
@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2021

⚠️ No Changeset found

Latest commit: d7c1d18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/7SYDyeiF7qwpPren7HPntJEyN1fS
✅ Preview: https://keystone-next-docs-git-noviny-fix-seed-data-keystonejs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 20, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Noviny Noviny force-pushed the noviny/fix-seed-data branch from 5ff842f to d7c1d18 Compare December 20, 2021 02:44
@vercel vercel bot temporarily deployed to Preview December 20, 2021 02:44 Inactive
@bladey bladey requested a review from dcousens December 20, 2021 23:04
@bladey bladey merged commit 618e52f into main Dec 21, 2021
@bladey bladey deleted the noviny/fix-seed-data branch December 21, 2021 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants