Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt before reset without migrations #5344

Merged
merged 3 commits into from
Apr 1, 2021

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Apr 1, 2021

A note with the unexecutable steps case: you can't really test that right now because you can't actually make a field non-nullable in Keystone right now 🙃 . (unexecutable steps are basically all making a field with nulls non-nullable) Removing a field that has non-null values(this bit is important) is the easiest way to test the warnings case.

@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2021

🦋 Changeset detected

Latest commit: 1ef5db8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@keystone-next/keystone Minor
@keystone-next/test-utils-legacy Patch
@keystone-next/auth Major
@keystone-next/example-auth Patch
@keystone-next/app-basic Patch
@keystone-next/example-ecommerce Patch
keystone-next-app Patch
@keystone-next/example-roles Patch
@keystone-next/example-sandbox Patch
@keystone-next/example-todo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/2LfEryGszeJhumHvwbrDxC9FvCwq
✅ Preview: https://keystone-next-git-prompt-before-reset-without-migration-ad3c9a.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 1, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1ef5db8:

Sandbox Source
@keystone-next/example-sandbox Configuration

@emmatown emmatown requested a review from timleslie April 1, 2021 04:03
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emmatown emmatown merged commit 901817f into master Apr 1, 2021
@emmatown emmatown deleted the prompt-before-reset-without-migrations branch April 1, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants