Fix appending wrong search query when routing #3221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 9a41475 We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
singhArmani
force-pushed
the
remove-location-search-error
branch
from
c1a0139 to
a848894
Compare
Upon filtering out the lists based on the ids, an error could occur. Irrespective of the error, we were still storing the search value into the localStorage. And when user transit back to this list page, the error would persist as we append the search query onto the URL. This fix looks into any API error, and removes the localStorage search value `location.search`, which gets set when **Filter** form is submitted.
singhArmani
force-pushed
the
remove-location-search-error
branch
from
a848894 to
0c08d3d
Compare
This was referenced Jul 2, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon filtering out the lists based on the ids, an error could occur.
Irrespective of the error, we were still storing the search value into
the localStorage.
And when user transit back to this list page, the error would persist as
we append the search query onto the URL.
This fix looks into any API error, and removes the localStorage search
value
location.search, which gets set when Filter form issubmitted.
See issue: #3075