Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove actions argument to hooks #3171

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Remove actions argument to hooks #3171

merged 1 commit into from
Jul 2, 2020

Conversation

timleslie
Copy link
Contributor

No description provided.

@request-info
Copy link

request-info bot commented Jun 17, 2020

It looks like we could use some more details. Good titles and descriptions help us fix things faster. If you can provide more information please update this issue.

@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2020 •
edited
Loading

🦋 Changeset is good to go

Latest commit: a279e92

We got this.

This PR includes changesets to release 31 packages
Name Type
@keystonejs/fields Major
@keystonejs/keystone Major
@keystonejs/api-tests Patch
@keystonejs/demo-custom-fields Patch
@keystonejs/app-admin-ui Patch
@keystonejs/auth-passport Patch
@keystonejs/auth-password Patch
@keystonejs/field-content Patch
@keystonejs/fields-authed-relationship Patch
@keystonejs/fields-auto-increment Patch
@keystonejs/fields-datetime-utc Patch
@keystonejs/fields-markdown Patch
@keystonejs/fields-mongoid Patch
@keystonejs/fields-wysiwyg-tinymce Patch
@keystonejs/list-plugins Patch
@keystonejs/demo-project-blog Patch
@keystonejs/demo-project-meetup Patch
@keystonejs/demo-project-todo Patch
@keystonejs/cypress-project-access-control Patch
@keystonejs/cypress-project-basic Patch
@keystonejs/cypress-project-client-validation Patch
@keystonejs/cypress-project-login Patch
@keystonejs/cypress-project-social-login Patch
@keystonejs/benchmarks Patch
@keystonejs/example-projects-nuxt Patch
@keystonejs/example-projects-starter Patch
@keystonejs/example-projects-todo Patch
@keystonejs/adapter-knex Patch
@keystonejs/adapter-mongoose Patch
@keystonejs/test-utils Patch
@keystonejs/example-projects-blank Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gautamsi
Copy link
Member

See my comments to other PR, we should leave thos for few major versions.

@timleslie timleslie force-pushed the remove-actions branch 2 times, most recently from 0f61898 to f01b313 Compare July 2, 2020 05:02
singhArmani
singhArmani reviewed Jul 2, 2020
View reviewed changes
Copy link
Contributor

@singhArmani singhArmani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

  • is this the desired changelog for this commit?

.changeset/nice-bags-type.md
}
```

See [the docs](/docs/discussions/server-side-graphql.md) for more details on how to use `context.executeGraphQL()`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changelog is exactly similar to what we have in #3169. Is this what we desire out of this commit? @timleslie

Copy link
Contributor Author

@timleslie timleslie Jul 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! There's a subtle difference, and they're covering different use cases, even though the solution for devs will lead them to the same place.

singhArmani
singhArmani approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@singhArmani singhArmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@timleslie timleslie merged commit 5fc97cb into master Jul 2, 2020
@timleslie timleslie deleted the remove-actions branch July 2, 2020 23:37
This was referenced Jul 2, 2020
Merged
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@singhArmani singhArmani singhArmani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timleslie @gautamsi @singhArmani