Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flow #2028

Merged
merged 7 commits into from
Dec 5, 2019
Merged

Remove flow #2028

merged 7 commits into from
Dec 5, 2019

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Dec 2, 2019

We've discussed it and we're going to remove Flow. Maintaining our usage of Flow has been causing more pain than the benefit we get out of it.

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2019

💥 No Changeset

Latest commit: df40e7c

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MadeByMike MadeByMike self-requested a review December 2, 2019 05:49
@gautamsi
Copy link
Member

gautamsi commented Dec 2, 2019

can we create a branch/tag which has Flow (just before this merge)? it would be helpful to use them when we go for TypeScript (soon hopefully). lot of typings can be copied to TypeScript as is even in jsdoc format.

see #1373

@emmatown
Copy link
Member Author

emmatown commented Dec 2, 2019

We don't really need to make a branch since we can look at the git history to get to a version of the repo with flow in it

@gautamsi
Copy link
Member

gautamsi commented Dec 2, 2019

A git tag would be helpful and easy to get to

@emmatown
Copy link
Member Author

emmatown commented Dec 2, 2019

Just pushed a flow tag from what is currently on master.

@timleslie timleslie merged commit e15501b into master Dec 5, 2019
@timleslie timleslie deleted the remove-flow branch December 5, 2019 04:40
@github-actions github-actions bot mentioned this pull request Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants