add icon to list name to indicate auth list #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: aaf3fe9 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This is good. I'd go with light grey, lighter than the text even and no hover color. We don't want this to steal attention it's a subtle indicator. It also needs more spacing on the left a to be vertically centred with the text. |
|
updated icon to |
MadeByMike
approved these changes
Oct 22, 2019
|
fixed after package org renamed. |
gautamsi
force-pushed
the
add-auth-list-icon
branch
from
5da82f0 to
954d8be
Compare
gautamsi
force-pushed
the
add-auth-list-icon
branch
from
954d8be to
52e601d
Compare
This was referenced Oct 25, 2019
Merged
gautamsi
added a commit
to gautamsi/keystone
that referenced
this pull request
Oct 27, 2019
* master: Version Packages (keystonejs#1827) Fix error "$in needs an array" when using mongoose adapter (keystonejs#1838) docs: add Fabyao as a contributor (keystonejs#1840) Set correct users link (keystonejs#1839) Doc updates and minor functionality improvements for file field/adapters (keystonejs#1817) Fix changeset package name (keystonejs#1836) add icon to list name to indicate auth list (keystonejs#1806) Use cypress-file-upload instead of custom implementation (fixes keystonejs#1180) (keystonejs#1815) Linked to official MongoDB installation tutorials (keystonejs#1828) Fixed broken link in Hooks guide (keystonejs#1835) exclude projects folder for easy contribution (keystonejs#1832) Update build-field-types tests and update lockfile (keystonejs#1811) Remove pluralization of Todo in list creation (keystonejs#1830) Improve create-keystone-app startup instructions (fixes keystonejs#1824) (keystonejs#1826)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #426
current PR (primary color on hover)
considered:
default:
alternate (solid primary color):
@MadeByMike if there is any preference in color, let me know.
I would also like to propose icon name for list config. so that anyone can add icon to the list name for visual indication. either a react fragment or named arch-ui icon.