Upgrade to next@9 in app-next #1378
Conversation
🦋 Changeset is good to goLatest commit: 09aba0d We got this. Not sure what this means? Click here to learn what changesets are. |
emmatown
requested review from
timleslie and
jesstelford
and removed request for
jesstelford and
timleslie
|
Just realised next-app has native support for next-routes, going to remove that now. |
There was a problem hiding this comment.
Looks good to me @mitchellhamilton
I'm actually not really happy about the change to the Link component now we've lost next-routes, I can see this becoming a nightmare to maintain correctly:
<Link href={`/event/[id]?hex=${hex}`} as={`/event/${id}?hex=${hex}`} passHref>
The whole as API of Next links has always really bugged me. But that's a Next issue, and feels like something we could deal with at the app level with a custom Link component or something when it's important.
Let's get this shipped! 🎉
| @@ -50,7 +50,8 @@ const EventItem = event => { | |||
| }} | |||
| > | |||
| <div css={{ maxHeight: 400, overflow: 'hidden' }}> | |||
| <Link route="event" params={{ id, hex }} passHref> | |||
| {/* TODO: this might be wrong */} | |||
| <Link href={`/event/[id]?hex=${hex}`} as={`/event/${id}?hex=${hex}`} passHref> | |||
There was a problem hiding this comment.
I have no idea why the hex is here, but since it's not a change, I'm not worried about that for this PR
|
Update: regarding that awkward |
No description provided.