Fix Admin UI not allowing negative values for float, decimal and inte…

…ger (#5113)
keystonejs · Mar 15, 2021 · ec6f9b6 · ec6f9b6 · vercel · Mar 15, 2021
1 parent c2426c3
commit ec6f9b6
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/.changeset/nasty-chairs-roll.md b/.changeset/nasty-chairs-roll.md
@@ -0,0 +1,5 @@
+---
+'@keystone-next/fields': patch
+---
+
+Fixed Admin UI not allowing negative values for float, decimal and integer
diff --git a/packages-next/fields/src/types/decimal/views/index.tsx b/packages-next/fields/src/types/decimal/views/index.tsx
@@ -18,7 +18,7 @@ export const Field = ({ field, value, onChange, autoFocus }: FieldProps<typeof c
     {onChange ? (
       <TextInput
         autoFocus={autoFocus}
-        onChange={event => onChange(event.target.value.replace(/[^\d\.]/, ''))}
+        onChange={event => onChange(event.target.value.replace(/[^\d\.-]/, ''))}
         value={value}
       />
     ) : (
@@ -60,7 +60,7 @@ export const controller = (config: Config): FieldController<string, string> => {
         return (
           <TextInput
             onChange={event => {
-              props.onChange(event.target.value.replace(/[^\d\.,\s]/g, ''));
+              props.onChange(event.target.value.replace(/[^\d\.,\s-]/g, ''));
             }}
             value={props.value}
             autoFocus={props.autoFocus}

diff --git a/packages-next/fields/src/types/float/views/index.tsx b/packages-next/fields/src/types/float/views/index.tsx
@@ -18,7 +18,7 @@ export const Field = ({ field, value, onChange, autoFocus }: FieldProps<typeof c
     {onChange ? (
       <TextInput
         autoFocus={autoFocus}
-        onChange={event => onChange(event.target.value.replace(/[^\d\.]/, ''))}
+        onChange={event => onChange(event.target.value.replace(/[^\d\.-]/, ''))}
         value={value}
       />
     ) : (
@@ -58,7 +58,7 @@ export const controller = (config: FieldControllerConfig): FieldController<strin
         return (
           <TextInput
             onChange={event => {
-              props.onChange(event.target.value.replace(/[^\d\.,\s]/g, ''));
+              props.onChange(event.target.value.replace(/[^\d\.,\s-]/g, ''));
             }}
             value={props.value}
             autoFocus={props.autoFocus}

diff --git a/packages-next/fields/src/types/integer/views/index.tsx b/packages-next/fields/src/types/integer/views/index.tsx
@@ -20,7 +20,7 @@ export const Field = ({ field, value, onChange, autoFocus }: FieldProps<typeof c
         autoFocus={autoFocus}
         type="number"
         onChange={event => {
-          onChange(event.target.value.replace(/\D/g, ''));
+          onChange(event.target.value.replace(/[^\d-]/g, ''));
         }}
         value={value}
       />
@@ -62,7 +62,7 @@ export const controller = (config: FieldControllerConfig): FieldController<strin
           <TextInput
             type="number"
             onChange={event => {
-              props.onChange(event.target.value.replace(/[^\d,\s]/g, ''));
+              props.onChange(event.target.value.replace(/[^\d,\s-]/g, ''));
             }}
             value={props.value}
             autoFocus={props.autoFocus}